From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] tools/xl: Fix build error following c/s f52fbcf7 Date: Thu, 9 Jul 2015 15:20:53 +0100 Message-ID: <1436451653.23508.136.camel@citrix.com> References: <1436438182-16305-1-git-send-email-andrew.cooper3@citrix.com> <1436438863.23508.107.camel@citrix.com> <20150709133103.GH3333@pengc-linux.bj.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150709133103.GH3333@pengc-linux.bj.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chao Peng Cc: Andrew Cooper , Ian Jackson , Wei Liu , Xen-devel List-Id: xen-devel@lists.xenproject.org On Thu, 2015-07-09 at 21:31 +0800, Chao Peng wrote: > On Thu, Jul 09, 2015 at 11:47:43AM +0100, Ian Campbell wrote: > > On Thu, 2015-07-09 at 11:36 +0100, Andrew Cooper wrote: > > > CentOS7 complains that 'ret' might be unused, and indeed this is the case for > > > `xl psr-hwinfo --cat`. > > > > > > The logic for selecting which information to print was rather awkward. > > > Introduce a new 'all' which default to true, and is cleared if specific > > > options are selected. This allows for a far more clear logic when choosing > > > whether to print information or not. > > > > > > Signed-off-by: Andrew Cooper > > > > Acked-by: Ian Campbell > > > > I'll wait a bit before applying to give Chao a chance to have a look. > > Thanks and I verified it successfully on my psr-enabled box. Thanks. I converted this into a Tested-by: Chao Peng and have applied.