All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Tamas K Lengyel <tlengyel@novetta.com>
Cc: kevin.tian@intel.com, wei.liu2@citrix.com,
	jun.nakajima@intel.com, rcojocaru@bitdefender.com,
	stefano.stabellini@eu.citrix.com, eddie.dong@intel.com,
	ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
	jbeulich@suse.com, andrew.cooper3@citrix.com, keir@xen.org
Subject: Re: [PATCH v5 2/4] x86/vm_event: toggle singlestep from vm_event response
Date: Fri, 10 Jul 2015 12:36:56 +0100	[thread overview]
Message-ID: <1436528216.23508.270.camel@citrix.com> (raw)
In-Reply-To: <1436447656-16334-2-git-send-email-tlengyel@novetta.com>

On Thu, 2015-07-09 at 09:14 -0400, Tamas K Lengyel wrote:
>  xen/include/asm-arm/vm_event.h | 31 +++++++++++++++++++++++++++++++

Acked-by: Ian Campbell <Ian.campbell@citrix.com>

> diff --git a/xen/arch/x86/vm_event.c b/xen/arch/x86/vm_event.c
> new file mode 100644
> index 0000000..c390225
> --- /dev/null
> +++ b/xen/arch/x86/vm_event.c
> @@ -0,0 +1,41 @@
> +/*
> + * arch/x86/vm_event.c
> + *
> + * Architecture-specific vm_event handling routines
> + *
> + * Copyright (c) 2015 Tamas K Lengyel (tamas@tklengyel.com)
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public
> + * License v2 as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public
> + * License along with this program; if not, write to the
> + * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
> + * Boston, MA 021110-1307, USA.

FYI I think current best practice is to omit the paragraph with the
address.

The more so because this is not AIUI their current address...

This shouldn't block acceptance of the patch though IMHO

  parent reply	other threads:[~2015-07-10 11:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 13:14 [PATCH v5 1/4] x86/monitor: add get_capabilities to monitor_op domctl Tamas K Lengyel
2015-07-09 13:14 ` [PATCH v5 2/4] x86/vm_event: toggle singlestep from vm_event response Tamas K Lengyel
2015-07-10 10:30   ` Jan Beulich
2015-07-10 11:36   ` Ian Campbell [this message]
2015-07-10 14:33     ` Lengyel, Tamas
2015-07-09 13:14 ` [PATCH v5 3/4] x86/monitor: don't use hvm_funcs directly Tamas K Lengyel
2015-07-09 13:20   ` Razvan Cojocaru
2015-07-09 13:14 ` [PATCH v5 4/4] MAINTAINERS: support for xen-access Tamas K Lengyel
2015-07-09 13:17   ` Razvan Cojocaru
2015-07-09 13:50     ` Lengyel, Tamas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436528216.23508.270.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=eddie.dong@intel.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jun.nakajima@intel.com \
    --cc=keir@xen.org \
    --cc=kevin.tian@intel.com \
    --cc=rcojocaru@bitdefender.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tlengyel@novetta.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.