All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	Peter Hurley <peter@hurleysoftware.com>
Subject: [PATCH 7/7] pty: Add debug message for ptmx open
Date: Sun, 12 Jul 2015 22:49:13 -0400	[thread overview]
Message-ID: <1436755753-7746-8-git-send-email-peter@hurleysoftware.com> (raw)
In-Reply-To: <1436755753-7746-1-git-send-email-peter@hurleysoftware.com>

Opens of /dev/ptmx don't use tty_open() so debug messages are
not printed for those opens; print a debug message with the
open count (which must always be 1) if TTY_DEBUG_HANGUP is defined.

NB: Each tty core source file undefs support for debug messages.
The relevant source file must be patched/edited to enable these
messages.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
 drivers/tty/pty.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c
index 4d5e840..4d5937c 100644
--- a/drivers/tty/pty.c
+++ b/drivers/tty/pty.c
@@ -26,6 +26,12 @@
 #include <linux/mutex.h>
 #include <linux/poll.h>
 
+#undef TTY_DEBUG_HANGUP
+#ifdef TTY_DEBUG_HANGUP
+# define tty_debug_hangup(tty, f, args...)	tty_debug(tty, f, ##args)
+#else
+# define tty_debug_hangup(tty, f, args...)	do {} while (0)
+#endif
 
 #ifdef CONFIG_UNIX98_PTYS
 static struct tty_driver *ptm_driver;
@@ -779,6 +785,8 @@ static int ptmx_open(struct inode *inode, struct file *filp)
 	if (retval)
 		goto err_release;
 
+	tty_debug_hangup(tty, "(tty count=%d)\n", tty->count);
+
 	tty_unlock(tty);
 	return 0;
 err_release:
-- 
2.4.5

      parent reply	other threads:[~2015-07-13  2:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13  2:49 [PATCH 0/7] tty core debug patches Peter Hurley
2015-07-13  2:49 ` [PATCH 1/7] tty: core: Improve debug message content Peter Hurley
2015-07-13  2:49 ` [PATCH 2/7] tty: core: Add tty_debug() for printk(KERN_DEBUG) messages Peter Hurley
2015-07-13  3:47   ` Joe Perches
2015-07-13  4:25     ` Peter Hurley
2015-07-13  4:30       ` Joe Perches
2015-07-13  4:40         ` Peter Hurley
2015-07-24  1:35   ` Greg Kroah-Hartman
2015-08-05 18:33     ` Peter Hurley
2015-08-05 19:22       ` Greg Kroah-Hartman
2015-07-13  2:49 ` [PATCH 3/7] tty: Replace #ifdef TTY_DEBUG_HANGUP with tty_debug_hangup() Peter Hurley
2015-07-13  2:49 ` [PATCH 4/7] tty: Use tty_debug() for tty_ldisc_debug() Peter Hurley
2015-07-13  2:49 ` [PATCH 5/7] tty: Replace inline #ifdef TTY_DEBUG_WAIT_UNTIL_SENT Peter Hurley
2015-07-13  2:49 ` [PATCH 6/7] tty: core: Improve ldisc debug messages Peter Hurley
2015-07-13  2:49 ` Peter Hurley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436755753-7746-8-git-send-email-peter@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.