All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Tao <tao.peng@primarydata.com>
To: linux-nfs@vger.kernel.org
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	Peng Tao <tao.peng@primarydata.com>
Subject: [PATCH 7/7] nfs42: respect clone_blksize
Date: Mon, 13 Jul 2015 13:50:55 +0800	[thread overview]
Message-ID: <1436766655-10696-8-git-send-email-tao.peng@primarydata.com> (raw)
In-Reply-To: <1436766655-10696-1-git-send-email-tao.peng@primarydata.com>

draft-ietf-nfsv4-minorversion2-38.txt says:
   Both cl_src_offset and
   cl_dst_offset must be aligned to the clone block size Section 12.2.1.
   The number of bytes to be cloned must be a multiple of the clone
   block size, except in the case in which cl_src_offset plus the number
   of bytes to be cloned is equal to the source file size.

Signed-off-by: Peng Tao <tao.peng@primarydata.com>
---
 fs/nfs/nfs4file.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/fs/nfs/nfs4file.c b/fs/nfs/nfs4file.c
index dfa6620..e450a5f 100644
--- a/fs/nfs/nfs4file.c
+++ b/fs/nfs/nfs4file.c
@@ -173,8 +173,10 @@ nfs42_ioctl_clone(struct file *dst_file, unsigned long srcfd,
 		  u64 src_off, u64 dst_off, u64 count)
 {
 	struct inode *dst_inode = file_inode(dst_file);
+	struct nfs_server *server = NFS_SERVER(dst_inode);
 	struct fd src_file;
 	struct inode *src_inode;
+	unsigned int bs = server->clone_blksize;
 	int ret;
 
 	/* dst file must be opened for writing */
@@ -212,6 +214,15 @@ nfs42_ioctl_clone(struct file *dst_file, unsigned long srcfd,
 	    src_inode->i_sb != dst_inode->i_sb)
 		goto out_fput;
 
+	/* check alignment w.r.t. clone_blksize */
+	ret = -EINVAL;
+	if (bs) {
+		if (!IS_ALIGNED(src_off, bs) || !IS_ALIGNED(dst_off, bs))
+			goto out_fput;
+		if (!IS_ALIGNED(count, bs) && i_size_read(src_inode) != (src_off + count))
+			goto out_fput;
+	}
+
 	/* XXX: do we lock at all? what if server needs CB_RECALL_LAYOUT? */
 	if (dst_inode < src_inode) {
 		mutex_lock_nested(&dst_inode->i_mutex, I_MUTEX_PARENT);
-- 
1.8.3.1


  parent reply	other threads:[~2015-07-13  5:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13  5:50 [PATCH 0/7] nfs: minor cleanups and NFSv42 CLONE support Peng Tao
2015-07-13  5:50 ` [PATCH 1/7] nfs42: decode_layoutstats does not need res parameter Peng Tao
2015-07-13  6:56   ` Christoph Hellwig
2015-07-13  5:50 ` [PATCH 2/7] nfs42: remove unused declaration Peng Tao
2015-07-13  6:57   ` Christoph Hellwig
2015-07-13  5:50 ` [PATCH 3/7] nfs42: add CLONE xdr functions Peng Tao
2015-07-13  5:50 ` [PATCH 4/7] nfs42: add CLONE proc functions Peng Tao
2015-07-13  5:50 ` [PATCH 5/7] nfs42: add NFS_IOC_CLONE ioctl Peng Tao
2015-07-13  5:50 ` [PATCH 6/7] nfs: get clone_blksize when probing fsinfo Peng Tao
2015-07-13  5:50 ` Peng Tao [this message]
2015-07-13  6:56 ` [PATCH 0/7] nfs: minor cleanups and NFSv42 CLONE support Christoph Hellwig
2015-07-13  7:30   ` Peng Tao
2015-07-13  7:30     ` Peng Tao
2015-07-13  7:40     ` Christoph Hellwig
2015-07-13  7:48       ` Peng Tao
2015-07-13  7:48         ` Peng Tao
2015-07-13  6:58 ` Christoph Hellwig
2015-07-13  7:36   ` Peng Tao
2015-07-13  7:41     ` Christoph Hellwig
2015-07-13  7:53       ` Peng Tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436766655-10696-8-git-send-email-tao.peng@primarydata.com \
    --to=tao.peng@primarydata.com \
    --cc=anna.schumaker@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.