From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST v2 10/13] TestSupport: don't put kernel='hvmloader' in HVM config Date: Mon, 13 Jul 2015 12:28:17 +0100 Message-ID: <1436786897.7019.109.camel@citrix.com> References: <1436718036-7985-1-git-send-email-wei.liu2@citrix.com> <1436718036-7985-11-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZEbuJ-00047N-Jt for xen-devel@lists.xenproject.org; Mon, 13 Jul 2015 11:28:23 +0000 In-Reply-To: <1436718036-7985-11-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Xen-devel , ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Sun, 2015-07-12 at 17:20 +0100, Wei Liu wrote: > Setting kernel to hvmloader is ignored in xl but not in libvirt. Libvirt > config converter will translate that then pass it to QEMU. QEMU > complains there is no kernel called hvmloader and exits. > > Just remove this option. Xl is not affected and libvirt will be able to > create HVM guest. > > Signed-off-by: Wei Liu > --- > Not sure if this affects Xend. We seem to only have one test case for > xend in 4.3. I fear it might indeed break things for 4.3 and older with xend. > --- > Osstest/TestSupport.pm | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm > index 66dc218..5336079 100644 > --- a/Osstest/TestSupport.pm > +++ b/Osstest/TestSupport.pm > @@ -1625,7 +1625,6 @@ sub more_prepareguest_hvm ($$$$;@) { > my $disks = join ",\t\t\n", map { "'$_'" } @disks; > > my $cfg = < -kernel = 'hvmloader' > builder = 'hvm' > # > disk = [