From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZEcQj-0005n6-Me for mharc-qemu-trivial@gnu.org; Mon, 13 Jul 2015 08:01:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEcQg-0005j4-No for qemu-trivial@nongnu.org; Mon, 13 Jul 2015 08:01:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZEcQg-0004wm-1X for qemu-trivial@nongnu.org; Mon, 13 Jul 2015 08:01:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56291) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEcQZ-0004vO-Ls; Mon, 13 Jul 2015 08:01:43 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 42965BAEC7; Mon, 13 Jul 2015 12:01:43 +0000 (UTC) Received: from nilsson.home.kraxel.org (ovpn-116-52.ams2.redhat.com [10.36.116.52]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6DC1fOq006313; Mon, 13 Jul 2015 08:01:41 -0400 Message-ID: <1436788900.26533.25.camel@redhat.com> From: Gerd Hoffmann To: Peter Maydell Date: Mon, 13 Jul 2015 14:01:40 +0200 In-Reply-To: <1436788098.26533.22.camel@redhat.com> References: <1436772617-2490-1-git-send-email-kraxel@redhat.com> <1436788098.26533.22.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: QEMU Trivial , Paolo Bonzini , QEMU Developers Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] virtio-input: enable on non-linux hosts X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2015 12:01:52 -0000 On Mo, 2015-07-13 at 13:48 +0200, Gerd Hoffmann wrote: > On Mo, 2015-07-13 at 09:56 +0100, Peter Maydell wrote: > > On 13 July 2015 at 08:30, Gerd Hoffmann wrote: > > > As we include a copy of the linux input layer header file in the qemu > > > source tree (include/standard-headers/linux/input.h) the virtio-input > > > bits (except pass-through) should build and work just fine on non-linux > > > hosts too. Tweak Makefile accordingly. > > > > Does "should" here mean "I haven't actually tested it" ? :-) > > Did a build test on freebsd -- passed. Oops, the windows cross builds fails though (due to include/standard-headers/linux/input.h including sys/ioctl.h). Ok, scratch that one, back to the drawing board ... sorry, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZEcQf-0005iv-7O for qemu-devel@nongnu.org; Mon, 13 Jul 2015 08:01:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZEcQZ-0004va-Re for qemu-devel@nongnu.org; Mon, 13 Jul 2015 08:01:49 -0400 Message-ID: <1436788900.26533.25.camel@redhat.com> From: Gerd Hoffmann Date: Mon, 13 Jul 2015 14:01:40 +0200 In-Reply-To: <1436788098.26533.22.camel@redhat.com> References: <1436772617-2490-1-git-send-email-kraxel@redhat.com> <1436788098.26533.22.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio-input: enable on non-linux hosts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Trivial , Paolo Bonzini , QEMU Developers On Mo, 2015-07-13 at 13:48 +0200, Gerd Hoffmann wrote: > On Mo, 2015-07-13 at 09:56 +0100, Peter Maydell wrote: > > On 13 July 2015 at 08:30, Gerd Hoffmann wrote: > > > As we include a copy of the linux input layer header file in the qemu > > > source tree (include/standard-headers/linux/input.h) the virtio-input > > > bits (except pass-through) should build and work just fine on non-linux > > > hosts too. Tweak Makefile accordingly. > > > > Does "should" here mean "I haven't actually tested it" ? :-) > > Did a build test on freebsd -- passed. Oops, the windows cross builds fails though (due to include/standard-headers/linux/input.h including sys/ioctl.h). Ok, scratch that one, back to the drawing board ... sorry, Gerd