Re: [PATCH 1/9] libxl: fix libxl__abs_path

[Ian Campbell <ian.campbell@citrix.com>]

On Mon, 2015-07-13 at 18:12 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH 1/9] libxl: fix libxl__abs_path"):
> > I rather dislike subjects of the form "fix $function", since it gives
> > very little clue to someone reading the shortlog what is going on.
> 
> Yes.
> 
> > In this case I think "libxl: make libxl__abs_path correctly handle a
> > NULL argument" would be an accurate description.
> 
> But: it is quite surprising that libxl__abs_path can be legally passed
> a NULL for any of its parameters.

True.
> 
> There are no call sites in libxl which can pass a NULL.
> 
> I think that if we are to retain this feature, it ought to be
> documented, at least.
> 
> Maybe
> 
>   _hidden char *libxl__abs_path(libxl__gc *gc,
>                                 const char *s /* NULL OK */,
>                                 const char *path);

Or add an assert if we don't wish to support this?