From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 10/10] libxl: fix caller of libxl_cpupool functions Date: Tue, 14 Jul 2015 11:37:43 +0200 Message-ID: <1436866663.13522.71.camel@citrix.com> References: <1436804541-12965-1-git-send-email-wei.liu2@citrix.com> <1436804541-12965-11-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7605351550228088759==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZEwf0-0000rF-FM for xen-devel@lists.xenproject.org; Tue, 14 Jul 2015 09:37:58 +0000 In-Reply-To: <1436804541-12965-11-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Xen-devel , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org --===============7605351550228088759== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-jD9IMKp1scYdwyPK6wwT" --=-jD9IMKp1scYdwyPK6wwT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2015-07-13 at 17:22 +0100, Wei Liu wrote: > Coverity complains cpupool_info leaks a string in failure path. Instead > of fixing that path, we rely on the callers (two public APIs at the > moment) of cpupool_info correctly call libxl_cpupoolinfo_dispose in > their failure path to dispose of any resources. >=20 > That involves: > 1. Call _init and _dispose in libxl_list_cpupool > 2. Call _init in numa_place_domain >=20 > Fix numa_place_domain to use goto style to make things more clearer. >=20 > Signed-off-by: Wei Liu > Reviewed-by: Dario Faggioli Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-jD9IMKp1scYdwyPK6wwT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlWk2HAACgkQk4XaBE3IOsRmfQCcCiVwkOLO7ar8XHJS/NUng0Mu 6ccAn0Hqs5unWlHMjslCUs3/uuR7N1iu =nyVD -----END PGP SIGNATURE----- --=-jD9IMKp1scYdwyPK6wwT-- --===============7605351550228088759== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============7605351550228088759==--