From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH] sysctl: adjust XEN_SYSCTL_numainfo behavior
Date: Tue, 14 Jul 2015 14:35:25 +0200
Message-ID: <1436877325.13522.87.camel@citrix.com>
References: <55A4F7F002000078000908B4@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8794993234201277054=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=630d3a084=dario.faggioli@citrix.com>)
	id 1ZEzQz-0006vk-D2
	for xen-devel@lists.xenproject.org; Tue, 14 Jul 2015 12:35:41 +0000
In-Reply-To: <55A4F7F002000078000908B4@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@eu.citrix.com>, xen-devel <xen-devel@lists.xenproject.org>, Boris Ostrovsky <boris.ostrovsky@oracle.com>
List-Id: xen-devel@lists.xenproject.org

--===============8794993234201277054==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-C5/5IHYaPY2fWm6reLJx"

--=-C5/5IHYaPY2fWm6reLJx
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2015-07-14 at 10:52 +0100, Jan Beulich wrote:
> ... to match XEN_SYSCTL_cputopoinfo, allowing the caller to get what it
> needs (if e.g. it's after the data for just one specific node) with
> just one hypercall, without caring about the total number of nodes in
> the system.
>=20
> Suggested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>=20
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

One question:

> --- a/xen/common/sysctl.c
> +++ b/xen/common/sysctl.c
> =20
> @@ -335,7 +329,7 @@ long do_sysctl(XEN_GUEST_HANDLE_PARAM(xe
>          else
>              i =3D num_nodes;
> =20
> -        if ( (!ret || (ret =3D=3D -ENOBUFS)) && (ni->num_nodes !=3D i) )
> +        if ( !ret && (ni->num_nodes !=3D i) )
>          {
Can't we kill the parentheses around the second argument of the && ?

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

--=-C5/5IHYaPY2fWm6reLJx
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlWlAhUACgkQk4XaBE3IOsTaNACgm62s+0BGrjJmliFEbdbT87Yi
OWUAnjr5A945jg56ibGP0IoLKuvQmSWp
=fGMm
-----END PGP SIGNATURE-----

--=-C5/5IHYaPY2fWm6reLJx--


--===============8794993234201277054==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============8794993234201277054==--