Re: [PATCH V5 0/3] Vm_event memory introspection helpers

[Ian Campbell <ian.campbell@citrix.com>]

On Tue, 2015-07-14 at 14:45 +0300, Razvan Cojocaru wrote:
> On 07/14/2015 01:50 PM, Jan Beulich wrote:
> >>>> On 13.07.15 at 19:14, <rcojocaru@bitdefender.com> wrote:
> >> I've also moved x86 logic in patch 3/3 to x86 source files, this
> >> seems to have gone unnoticed but would likely have not compiled
> >> on ARM.
> > 
> > Which leaves open whether this time you actually checked that
> > ARM continues to build.
> 
> I did check, and again just now. My patches don't break the ARM build,
> but I just found that on my ARM system, current Xen staging doesn't
> build: http://pastebin.com/RnywiCX7

This is a glibc error with your distro, like this
https://bugs.launchpad.net/linaro-aarch64/+bug/1169164

> I've temporarily fixed that by wrapping the offending #defines in
> "#ifndef constant" statements, so that I could continue to check that
> the build works, but that's likely not the proper fix.

Indeed, it the hack which works if you are unable to upgrade your libc
for some reason. FWIW I just applied the patches from that bug to the
installed copies of the relevant headers, which is certainly skanky...

Ian.