From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH for 4.6] tools/python: Correct the install
 path of the python scripts
Date: Wed, 15 Jul 2015 12:43:28 +0100
Message-ID: <1436960608.32371.14.camel@citrix.com>
References: <1436958580-2842-1-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1436958580-2842-1-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-07-15 at 12:09 +0100, Andrew Cooper wrote:
> c/s 74a7c7a was actually written long before c/s 2c96ecb "Use
> configure --libexecdir=BASEDIR to set LIBEXEC", and I didn't notice
> during development because of the method I was using to run a legacy
> and migration v2 libxl toolstack side-by-side.
> 
> The result is that the conversion script gets installed in the root of
> the output tree, rather than in the location libxl is expecting to
> find it.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Ian Campbell <Ian.Campbell@citrix.com>

and applied.

> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> ---
>  tools/python/Makefile |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/python/Makefile b/tools/python/Makefile
> index df942a7..8d2c7dd 100644
> --- a/tools/python/Makefile
> +++ b/tools/python/Makefile
> @@ -17,12 +17,12 @@ build: genwrap.py $(XEN_ROOT)/tools/libxl/libxl_types.idl \
>  
>  .PHONY: install
>  install:
> -	$(INSTALL_DIR) $(DESTDIR)$(PRIVATE_BINDIR)
> +	$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
>  
>  	CC="$(CC)" CFLAGS="$(PY_CFLAGS)" $(PYTHON) setup.py install \
>  		$(PYTHON_PREFIX_ARG) --root="$(DESTDIR)" --force
>  
> -	$(INSTALL_PROG) scripts/convert-legacy-stream $(DESTDIR)$(PRIVATE_BINDIR)
> +	$(INSTALL_PROG) scripts/convert-legacy-stream $(DESTDIR)$(LIBEXEC_BIN)
>  
>  .PHONY: test
>  test: