All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Cc: Michael Welling <mwelling@emacinc.com>,
	Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sebastian Reichel <sre@kernel.org>
Subject: [PATCH 4/4] Input: tsc2005 - convert to gpiod
Date: Wed, 15 Jul 2015 14:13:28 +0200	[thread overview]
Message-ID: <1436962408-5206-5-git-send-email-sre@kernel.org> (raw)
In-Reply-To: <1436962408-5206-1-git-send-email-sre@kernel.org>

Convert driver to descriptor based GPIO API. Also
fix the after-probe reset GPIO state, so that the
device is not kept in reset state.

Signed-off-by: Sebastian Reichel <sre@kernel.org>
---
 drivers/input/touchscreen/tsc2005.c | 25 ++++++++-----------------
 1 file changed, 8 insertions(+), 17 deletions(-)

diff --git a/drivers/input/touchscreen/tsc2005.c b/drivers/input/touchscreen/tsc2005.c
index 83508d8..cb08dc8 100644
--- a/drivers/input/touchscreen/tsc2005.c
+++ b/drivers/input/touchscreen/tsc2005.c
@@ -30,11 +30,11 @@
 #include <linux/delay.h>
 #include <linux/pm.h>
 #include <linux/of.h>
-#include <linux/of_gpio.h>
 #include <linux/spi/spi.h>
 #include <linux/spi/tsc2005.h>
 #include <linux/regulator/consumer.h>
 #include <linux/regmap.h>
+#include <linux/gpio/consumer.h>
 
 /*
  * The touchscreen interface operates as follows:
@@ -179,7 +179,7 @@ struct tsc2005 {
 
 	struct regulator	*vio;
 
-	int			reset_gpio;
+	struct gpio_desc	*reset_gpio;
 	void			(*set_reset)(bool enable);
 };
 
@@ -317,8 +317,8 @@ static void tsc2005_stop_scan(struct tsc2005 *ts)
 
 static void tsc2005_set_reset(struct tsc2005 *ts, bool enable)
 {
-	if (ts->reset_gpio >= 0)
-		gpio_set_value(ts->reset_gpio, enable);
+	if (ts->reset_gpio)
+		gpiod_set_value_cansleep(ts->reset_gpio, enable);
 	else if (ts->set_reset)
 		ts->set_reset(enable);
 }
@@ -611,19 +611,11 @@ static int tsc2005_probe(struct spi_device *spi)
 	ts->esd_timeout = esd_timeout;
 
 	if (np) {
-		ts->reset_gpio = of_get_named_gpio(np, "reset-gpios", 0);
-		if (ts->reset_gpio == -EPROBE_DEFER)
-			return ts->reset_gpio;
-		if (ts->reset_gpio < 0) {
+		ts->reset_gpio = devm_gpiod_get(&spi->dev, "reset",
+						GPIOD_OUT_HIGH);
+		if (IS_ERR(ts->reset_gpio)) {
+			error = PTR_ERR(ts->reset_gpio);
 			dev_err(&spi->dev, "error acquiring reset gpio: %d\n",
-				ts->reset_gpio);
-			return ts->reset_gpio;
-		}
-
-		error = devm_gpio_request_one(&spi->dev, ts->reset_gpio, 0,
-					      "reset-gpios");
-		if (error) {
-			dev_err(&spi->dev, "error requesting reset gpio: %d\n",
 				error);
 			return error;
 		}
@@ -635,7 +627,6 @@ static int tsc2005_probe(struct spi_device *spi)
 			return error;
 		}
 	} else {
-		ts->reset_gpio = -1;
 		ts->set_reset = pdata->set_reset;
 	}
 
-- 
2.1.4

  parent reply	other threads:[~2015-07-15 12:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15 12:13 [PATCH 0/4] [input] tsc2005 cleanup Sebastian Reichel
2015-07-15 12:13 ` [PATCH 1/4] Input: tsc2005 - improve readability of register defines Sebastian Reichel
2015-07-15 12:13 ` [PATCH 2/4] Input: tsc2005 - convert to regmap Sebastian Reichel
2015-07-15 21:29   ` Dmitry Torokhov
2015-07-15 21:48     ` Dmitry Torokhov
2015-07-15 21:54     ` Sebastian Reichel
2015-07-16  6:34   ` Dmitry Torokhov
2015-07-15 12:13 ` [PATCH 3/4] Input: tsc2005 - simplify drvdata acquisition Sebastian Reichel
2015-07-15 21:31   ` Dmitry Torokhov
2015-07-15 22:02     ` Sebastian Reichel
2015-07-16  0:22       ` Dmitry Torokhov
2015-07-15 12:13 ` Sebastian Reichel [this message]
2015-07-15 21:34   ` [PATCH 4/4] Input: tsc2005 - convert to gpiod Dmitry Torokhov
2015-07-15 22:09     ` Sebastian Reichel
2015-07-16  0:25       ` Dmitry Torokhov
2015-07-16  9:14         ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436962408-5206-5-git-send-email-sre@kernel.org \
    --to=sre@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mwelling@emacinc.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.