From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] make rangeset_report_ranges() report all
	ranges
Date: Wed, 15 Jul 2015 14:43:33 +0100
Message-ID: <1436967813.32371.73.camel@citrix.com>
References: <55A67702020000780009157E@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=631330d48=Ian.Campbell@citrix.com>)
	id 1ZFMyN-0007Nh-T8
	for xen-devel@lists.xenproject.org; Wed, 15 Jul 2015 13:43:44 +0000
In-Reply-To: <55A67702020000780009157E@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-07-15 at 14:06 +0100, Jan Beulich wrote:
> find_range() returns NULL when s is below the lowest range, so we have
> to use first_range() here (which is as good performance wise).

The bug here was that the first range would be omitted under certain
conditions? Saying which here would be interesting.

> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> 
> --- a/xen/common/rangeset.c
> +++ b/xen/common/rangeset.c
> @@ -289,7 +289,7 @@ int rangeset_report_ranges(
>  
>      read_lock(&r->lock);
>  
> -    for ( x = find_range(r, s); x && (x->s <= e) && !rc; x = next_range(r, x) )
> +    for ( x = first_range(r); x && (x->s <= e) && !rc; x = next_range(r, x) )
>          if ( x->e >= s )
>              rc = cb(max(x->s, s), min(x->e, e), ctxt);
>  
> 
> 
>