* [PATCH] libxl: event tests: Fix `=' vs `==' in fdderegrace
@ 2015-07-15 14:42 Ian Jackson
2015-07-15 14:43 ` Wei Liu
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ian Jackson @ 2015-07-15 14:42 UTC (permalink / raw)
To: xen-devel; +Cc: Ian Jackson, wei.liu2, ian.campbell, Andrew Cooper
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
---
tools/libxl/test_fdderegrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libxl/test_fdderegrace.c b/tools/libxl/test_fdderegrace.c
index b644d7a..f57965f 100644
--- a/tools/libxl/test_fdderegrace.c
+++ b/tools/libxl/test_fdderegrace.c
@@ -25,7 +25,7 @@ int main(int argc, char **argv) {
rc = libxl_event_check(ctx, &event, LIBXL_EVENTMASK_ALL, 0,0);
assert(!rc);
assert(event);
- assert(event->for_user = how.u.for_event);
+ assert(event->for_user == how.u.for_event);
assert(event->type == LIBXL_EVENT_TYPE_OPERATION_COMPLETE);
assert(event->u.operation_complete.rc == ERROR_ABORTED);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] libxl: event tests: Fix `=' vs `==' in fdderegrace
2015-07-15 14:42 [PATCH] libxl: event tests: Fix `=' vs `==' in fdderegrace Ian Jackson
@ 2015-07-15 14:43 ` Wei Liu
2015-07-15 14:44 ` Ian Campbell
2015-07-15 14:49 ` Andrew Cooper
2 siblings, 0 replies; 5+ messages in thread
From: Wei Liu @ 2015-07-15 14:43 UTC (permalink / raw)
To: Ian Jackson; +Cc: Andrew Cooper, xen-devel, wei.liu2, ian.campbell
On Wed, Jul 15, 2015 at 03:42:03PM +0100, Ian Jackson wrote:
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
> tools/libxl/test_fdderegrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/test_fdderegrace.c b/tools/libxl/test_fdderegrace.c
> index b644d7a..f57965f 100644
> --- a/tools/libxl/test_fdderegrace.c
> +++ b/tools/libxl/test_fdderegrace.c
> @@ -25,7 +25,7 @@ int main(int argc, char **argv) {
> rc = libxl_event_check(ctx, &event, LIBXL_EVENTMASK_ALL, 0,0);
> assert(!rc);
> assert(event);
> - assert(event->for_user = how.u.for_event);
> + assert(event->for_user == how.u.for_event);
> assert(event->type == LIBXL_EVENT_TYPE_OPERATION_COMPLETE);
> assert(event->u.operation_complete.rc == ERROR_ABORTED);
>
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] libxl: event tests: Fix `=' vs `==' in fdderegrace
2015-07-15 14:42 [PATCH] libxl: event tests: Fix `=' vs `==' in fdderegrace Ian Jackson
2015-07-15 14:43 ` Wei Liu
@ 2015-07-15 14:44 ` Ian Campbell
2015-07-15 14:49 ` Andrew Cooper
2 siblings, 0 replies; 5+ messages in thread
From: Ian Campbell @ 2015-07-15 14:44 UTC (permalink / raw)
To: Ian Jackson; +Cc: Andrew Cooper, xen-devel, wei.liu2
On Wed, 2015-07-15 at 15:42 +0100, Ian Jackson wrote:
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libxl: event tests: Fix `=' vs `==' in fdderegrace
2015-07-15 14:42 [PATCH] libxl: event tests: Fix `=' vs `==' in fdderegrace Ian Jackson
2015-07-15 14:43 ` Wei Liu
2015-07-15 14:44 ` Ian Campbell
@ 2015-07-15 14:49 ` Andrew Cooper
2015-07-15 15:02 ` Ian Jackson
2 siblings, 1 reply; 5+ messages in thread
From: Andrew Cooper @ 2015-07-15 14:49 UTC (permalink / raw)
To: Ian Jackson, xen-devel; +Cc: wei.liu2, ian.campbell
On 15/07/15 15:42, Ian Jackson wrote:
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
Seeing as everyone is jumping on this one, Reviewed-by: Andrew Cooper
<andrew.cooper3@citrix.com>
> ---
> tools/libxl/test_fdderegrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libxl/test_fdderegrace.c b/tools/libxl/test_fdderegrace.c
> index b644d7a..f57965f 100644
> --- a/tools/libxl/test_fdderegrace.c
> +++ b/tools/libxl/test_fdderegrace.c
> @@ -25,7 +25,7 @@ int main(int argc, char **argv) {
> rc = libxl_event_check(ctx, &event, LIBXL_EVENTMASK_ALL, 0,0);
> assert(!rc);
> assert(event);
> - assert(event->for_user = how.u.for_event);
> + assert(event->for_user == how.u.for_event);
> assert(event->type == LIBXL_EVENT_TYPE_OPERATION_COMPLETE);
> assert(event->u.operation_complete.rc == ERROR_ABORTED);
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] libxl: event tests: Fix `=' vs `==' in fdderegrace
2015-07-15 14:49 ` Andrew Cooper
@ 2015-07-15 15:02 ` Ian Jackson
0 siblings, 0 replies; 5+ messages in thread
From: Ian Jackson @ 2015-07-15 15:02 UTC (permalink / raw)
To: Andrew Cooper; +Cc: xen-devel, wei.liu2, ian.campbell
Andrew Cooper writes ("Re: [PATCH] libxl: event tests: Fix `=' vs `==' in fdderegrace"):
> On 15/07/15 15:42, Ian Jackson wrote:
> > Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > CC: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Seeing as everyone is jumping on this one, Reviewed-by: Andrew Cooper
> <andrew.cooper3@citrix.com>
Heh, thanks, committed.
Ratio of faff to code change is probably up to 10,000 by now...
Ian.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-07-15 15:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-15 14:42 [PATCH] libxl: event tests: Fix `=' vs `==' in fdderegrace Ian Jackson
2015-07-15 14:43 ` Wei Liu
2015-07-15 14:44 ` Ian Campbell
2015-07-15 14:49 ` Andrew Cooper
2015-07-15 15:02 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.