From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH (for 4.6)] x86/hvm: Unconditionally buffer
 writes to VRAM
Date: Thu, 16 Jul 2015 11:12:44 +0100
Message-ID: <1437041564.32371.145.camel@citrix.com>
References: <1437038675-14095-1-git-send-email-paul.durrant@citrix.com>
	<55A77AAA.8060301@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=63240c440=Ian.Campbell@citrix.com>)
	id 1ZFg9p-0005tU-Oi
	for xen-devel@lists.xenproject.org; Thu, 16 Jul 2015 10:12:49 +0000
In-Reply-To: <55A77AAA.8060301@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel@lists.xenproject.org, Paul Durrant <paul.durrant@citrix.com>, Keir Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-07-16 at 10:34 +0100, Andrew Cooper wrote:
> On 16/07/15 10:24, Paul Durrant wrote:
> > When c/s 3bbaaec09 "unify stdvga mmio intercept with standard mmio
> > intercept" was added, a small semantic change was made. Prior to
> > this patch the hypervisor unconditionally sent all guest writes
> > to the VGA aperture as buffered ioreqs, whereas after the patch it
> > only does this when the VGA model is in 'stdvga' mode (sequencer
> > register #7 == 0).
> >
> > When installing Windows 7 (64-bit) using the default QEMU VGA model
> > (== cirrus), Windows leaves 'stdvga' mode early in boot and hence
> > all further writes to the VGA aperture are done using synchronous
> > ioreqs which slows down boot by several orders of magnitude (thanks
> > to the elaborate splash screen that Windows presents). This can be
> > viewed as a regression and so this patch re-instates previous
> > buffering behaviour.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> > Tested-by: Wei Liu <wei.liu2@citrix.com>
> > Cc: Keir Fraser <keir@xen.org>
> > Cc: Jan Beulich <jbeulich@suse.com>
> > Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> This is unfortunate,

OOI why is it unfortunate? IOW why wouldn't we want buffer all accesses
to the VRAM (leaving aside that perhaps the original authors only
intended to do it for StdVGA).