From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH XEN v2 08/15] tools: Refactor
 /dev/xen/gnt{dev, shr} wrappers into libxengnttab.
Date: Thu, 16 Jul 2015 15:56:20 +0100
Message-ID: <1437058580.32371.224.camel@citrix.com>
References: <55A7C446.3050308@aero.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55A7C446.3050308@aero.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jason Andryuk <jason.p.andryuk@aero.org>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-07-16 at 10:48 -0400, Jason Andryuk wrote:
> Ian,
> 
> I'm not subscribed to xen-devel and read your patch from the gmane.org
> web interface.

No problem, I'm recopying the list for you now.

> > After this change libxenvchan no longer needs to link against
> > libxenctrl. It still needs xenctrl.h in one file for xen_mb and
> > friends.
> 
> @@ -109,7 +119,7 @@ LDLIBS_libxenstat  = $(SHDEPS_libxenstat) $(XEN_LIBXENSTAT)/libxenstat$(libexten
>  SHLIB_libxenstat   = $(SHDEPS_libxenstat) -Wl,-rpath-link=$(XEN_LIBXENSTAT)
>  
>  CFLAGS_libxenvchan = -I$(XEN_LIBVCHAN)
> -SHDEPS_libxenvchan = $(SHLIB_libxenctrl) $(SHLIB_libxenstore) $(SHLIB_libxenevtchn)
> +SHDEPS_libxenvchan = $(SHLIB_libxenctrl) $(SHLIB_libxenstore) $(SHLIB_libxenevtchn) $(SHLIB_libxengnttab) $(SHLIB_libxengntshr)
>  LDLIBS_libxenvchan = $(SHDEPS_libxenvchan) $(XEN_LIBVCHAN)/libxenvchan$(libextension)
>  SHLIB_libxenvchan  = $(SHDEPS_libxenvchan) -Wl,-rpath-link=$(XEN_LIBVCHAN)
>  
> I see in tools/libvchan/Makefile you removed $(LDLIBS_libxenctrl), but
> did you want to remove $(SHLIB_libxenctrl) here?

I think I did, yes, thanks.

Ian.