From: Joe Perches <joe@perches.com>
To: Craig Inches <craig.inches@navitas.com>
Cc: Craig Inches <craig.inches@xayto.net>,
lidza.louina@gmail.com, markh@compro.net,
gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: drivers: dgnc
Date: Thu, 16 Jul 2015 10:52:19 -0700 [thread overview]
Message-ID: <1437069139.2495.12.camel@perches.com> (raw)
In-Reply-To: <20150717002041.GA8792@Morat.xayto.local>
On Fri, 2015-07-17 at 00:20 +0000, Craig Inches wrote:
> Hi Joe,
Rehi Craig.
> On Thu, Jul 16, 2015 at 08:30:53AM -0700, Joe Perches wrote:
> > On Thu, 2015-07-16 at 23:11 +0000, Craig Inches wrote:
> > > Fixed up some checkpatch.pl style issues.
> > > Line greater than 80 Chars in multiple locations.
> >
> > I think most all of these are not improvements.
> Ok, can you be a little more specific? I did see some that where
> not worth modifying due to only being 1 or 2 chars over, and
> breaking the line seemed pointless.
Precisely.
Please don't do things you recognize as pointless
just to satisfy some brainless script.
> > Please use --strict when verifying your patches.
> Not sure where the --strict should be set? I cant see the option
> in the checklist.pl script
$ ./scripts/checkpatch.pl --help
[...]
--subjective, --strict enable more subjective tests
[...]
$
next prev parent reply other threads:[~2015-07-16 17:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 23:11 [PATCH] Staging: drivers: dgnc Craig Inches
2015-07-16 15:30 ` Joe Perches
2015-07-17 0:20 ` Craig Inches
2015-07-16 17:52 ` Joe Perches [this message]
2015-07-17 0:57 ` Craig Inches
2015-07-16 15:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437069139.2495.12.camel@perches.com \
--to=joe@perches.com \
--cc=craig.inches@navitas.com \
--cc=craig.inches@xayto.net \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.