From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iw: Use ifname if available, print new/del/stop events.
Date: Fri, 17 Jul 2015 10:55:21 +0200 [thread overview]
Message-ID: <1437123321.1933.2.camel@sipsolutions.net> (raw)
In-Reply-To: <55817A0F.2000207@candelatech.com>
On Wed, 2015-06-17 at 06:45 -0700, Ben Greear wrote:
>
> On 06/17/2015 02:14 AM, Johannes Berg wrote:
> > On Wed, 2015-06-10 at 18:17 -0400, greearb@candelatech.com wrote:
> > > From: Ben Greear <greearb@candelatech.com>
> > >
> > > If the kernel sends the IFNAME in the netlink message, then
> > > use it to save the call to map ifindex to name (and
> > > potentially fix races, especially when kernel is
> > > busy deleting an interface.
> >
> > Please split the "print new/del/stop events" part into a separate
> > patch
> > - I can apply that now.
>
> Some existing events (interface-delete, I think) already have the
> ifname, by the way..so the iw patch
> is useful without any kernel changes.
>
Fair enough. Still, splitting the patch would make sense I think.
johannes
prev parent reply other threads:[~2015-07-17 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 22:17 [PATCH] iw: Use ifname if available, print new/del/stop events greearb
2015-06-17 9:14 ` Johannes Berg
2015-06-17 13:45 ` Ben Greear
2015-07-17 8:55 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437123321.1933.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.