From: Joe Perches <joe@perches.com>
To: Joseph-Eugene Winzer <m999@openmailbox.org>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] drivers: staging: rtl8192u: fixed coding style issues in r8192U_core.c
Date: Fri, 17 Jul 2015 17:15:45 -0700 [thread overview]
Message-ID: <1437178545.2495.105.camel@perches.com> (raw)
In-Reply-To: <1437141560-22517-5-git-send-email-m999@openmailbox.org>
On Fri, 2015-07-17 at 15:59 +0200, Joseph-Eugene Winzer wrote:
> Fixed a few lines that were longer than 80 chars.
[]
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
[]
> @@ -212,7 +212,9 @@ static void rtl819x_set_channel_map(u8 channel_plan, struct r8192_priv *priv)
> ChannelPlan[channel_plan].Channel[i] >
> max_chan)
> break;
> - GET_DOT11D_INFO(ieee)->channel_map[ChannelPlan[channel_plan].Channel[i]] = 1;
> + GET_DOT11D_INFO(ieee)->
> + channel_map[ChannelPlan[channel_plan].
> + Channel[i]] = 1;
That's _very_ not nice to read.
Try using more temporaries instead.
index = ChannelPlan[channel_plan].Channel[i];
GET_DOT11D_INFO(ieee)->channel_map[index] = 1;
etc...
next prev parent reply other threads:[~2015-07-18 0:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 13:59 [PATCH 1/5] drivers: staging: rtl8192u: fixing coding style issues in r8192U_core.c Joseph-Eugene Winzer
2015-07-17 13:59 ` [PATCH 2/5] " Joseph-Eugene Winzer
2015-07-18 0:11 ` Joe Perches
2015-07-18 12:29 ` m999
2015-07-19 10:48 ` Dan Carpenter
2015-07-17 13:59 ` [PATCH 3/5] drivers: staging: rtl8192u: removed pointer check for kfree " Joseph-Eugene Winzer
2015-07-17 13:59 ` [PATCH 4/5] drivers: staging: rtl8192u: included linux/uaccess.h instead of asm/uaccess.h Joseph-Eugene Winzer
2015-07-17 13:59 ` [PATCH 5/5] drivers: staging: rtl8192u: fixed coding style issues in r8192U_core.c Joseph-Eugene Winzer
2015-07-18 0:15 ` Joe Perches [this message]
2015-07-23 4:02 ` [PATCH 1/5] drivers: staging: rtl8192u: fixing " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437178545.2495.105.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m999@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.