All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/upmpdcli: disable for PowerPC CS toolchains
Date: Sun, 19 Jul 2015 09:07:44 +0200	[thread overview]
Message-ID: <1437289664.12715.17.camel@embedded.rocks> (raw)
In-Reply-To: <20150718111610.55f5a57b@free-electrons.com>

Dear Thomas Petazzoni,

On Sa, 2015-07-18 at 11:16 +0200, Thomas Petazzoni wrote:
> Dear J?rg Krause,
> 
> On Fri, 17 Jul 2015 00:45:06 +0200, J?rg Krause wrote:
> > Those toolchains use gcc <= 4.5, which is too old as they are 
> > missing to
> > construct an empty std::shared_ptr with a nullptr (0) as an 
> > argument. This
> > is only introduced with gcc-4.6.
> > 
> > Fixes:
> > http://autobuild.buildroot.net/results/faf/faf1b071c0a5bd8395d79abf
> > 2e6a32169ad7f136
> > http://autobuild.buildroot.net/results/247/247b3f1ac3d3a9712e9410ee
> > f298fce8d885f92c
> > http://autobuild.buildroot.net/results/de6/de601c4d4dd7922895892d78
> > d3a37902fb98c7be
> > http://autobuild.buildroot.net/results/a4d/a4d7bf9863c134f59d285616
> > b9c1f78201bd1a3e
> > 
> > and many more.
> > 
> > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> > ---
> >  package/upmpdcli/Config.in | 4 ++++
> >  1 file changed, 4 insertions(+)
> 
> I've applied since it's the way we have been handling this so far.
> However, during the hackaton, we discussed this a little bit, and we
> believe we probably need to add some hidden Config.in options like
> "BR2_PACKAGE_GCC_AT_LEAST_4_5", "BR2_PACKAGE_GCC_AT_LEAST_4_8", so 
> that
> packages can depend on these options more easily.

I see! This would be indeed helpful.

Upstream submitted a patch regarding this build error which removes the
necessity for a gcc >= 4.6 toolchain. Shall I submit this upstream
patch to allow using the excluded toolchains again, or do we just wait
until a new version of upmpdcli will be released and we include them
again in that case?

Best regards
J?rg Krause

  reply	other threads:[~2015-07-19  7:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 22:45 [Buildroot] [PATCH 1/1] package/upmpdcli: disable for PowerPC CS toolchains Jörg Krause
2015-07-18  9:16 ` Thomas Petazzoni
2015-07-19  7:07   ` Jörg Krause [this message]
2015-07-19  8:11     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437289664.12715.17.camel@embedded.rocks \
    --to=joerg.krause@embedded.rocks \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.