diff for duplicates of <1437396397.10831.31.camel@transmode.se> diff --git a/a/1.txt b/N1/1.txt index 67cfb11..a0fa3ca 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,66 +1,55 @@ On Mon, 2015-07-20 at 12:18 +0000, Madalin-Cristian Bucur wrote: > Hi Joakim ->=20 +> > > -----Original Message----- > > From: Joakim Tjernlund [mailto:joakim.tjernlund@transmode.se] > > Sent: Monday, July 20, 2015 10:57 AM -> > To: linuxppc-dev@lists.ozlabs.org; netdev@vger.kernel.org; Bucur Madali= -n- +> > To: linuxppc-dev@lists.ozlabs.org; netdev@vger.kernel.org; Bucur Madalin- > > Cristian-B32716 > > Cc: linux-kernel@vger.kernel.org > > Subject: Re: [PATCH RFC 02/10] dpaa_eth: add support for DPAA Ethernet -> >=20 +> > > > On Mon, 2015-07-20 at 09:54 +0200, Joakim Tjernlund wrote: > > > On Wed, 2015-04-01 at 19:19 +0300, Madalin Bucur wrote: > > > > This introduces the Freescale Data Path Acceleration Architecture > > > > (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan, > > > > BMan, PAMU and FMan drivers to deliver Ethernet connectivity on > > > > the Freescale DPAA QorIQ platforms. -> > > >=20 +> > > > > > > > Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com> > > > > --- > > > .... > > > > + snprintf(net_dev->name, IFNAMSIZ, "fm%d-mac%d", > > > > + dpa_mac_fman_index_get(pdev), > > > > + dpa_mac_hw_index_get(pdev)); -> > >=20 -> > > Should ethernet drivers dictate interface name in user space nowadays= -? +> > > +> > > Should ethernet drivers dictate interface name in user space nowadays? > > > I would prefer if you didn't. ->=20 -> The preformatted interface name was thought as a helper for quick interfa= -ce -> identification. It also ensures constant naming of the interfaces, i.e. i= -f you +> +> The preformatted interface name was thought as a helper for quick interface +> identification. It also ensures constant naming of the interfaces, i.e. if you > add/remove PCI network cards. One can make use of udev rules to override > default interface names ("eth%d") in userspace. -I am not well versed in ethernet interface naming but I think you are just = -creating -another name space here. To me one either have the old eth%d names or let u= -dev do +I am not well versed in ethernet interface naming but I think you are just creating +another name space here. To me one either have the old eth%d names or let udev do the naming so there is some order w.r.t interface naming. -I also find it handy to be able to control which I/F is eth0 etc. just by c= -hanging -the order they are listed in the device tree. This makes our application ha= -ppy :) +I also find it handy to be able to control which I/F is eth0 etc. just by changing +the order they are listed in the device tree. This makes our application happy :) ->=20 -> Another reason for using this is that the interface name was also used fo= -r the +> +> Another reason for using this is that the interface name was also used for the > debugfs file name and when compiling dpaa_eth as a module there was a > problem with udev concurrently renaming interfaces from eth0 to something > like fmx-macy, making the next probed DPAA interface temporarily get the > eth0 name (before being renamed fmx-macw). Subsequently, -> the debugfs_create_file(net_dev->name,...) call failed because of duplica= -ted +> the debugfs_create_file(net_dev->name,...) call failed because of duplicated > names. ->=20 -> If this is considered more of a bug than a feature, I can remove it and o= -nly change +> +> If this is considered more of a bug than a feature, I can remove it and only change > the naming of the debugfs entries to avoid the udev issue. Perhaps netdev list can advise? - Jocke= + Jocke diff --git a/a/content_digest b/N1/content_digest index 8d2d962..4793fc3 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -13,69 +13,58 @@ "b\0" "On Mon, 2015-07-20 at 12:18 +0000, Madalin-Cristian Bucur wrote:\n" "> Hi Joakim\n" - ">=20\n" + "> \n" "> > -----Original Message-----\n" "> > From: Joakim Tjernlund [mailto:joakim.tjernlund@transmode.se]\n" "> > Sent: Monday, July 20, 2015 10:57 AM\n" - "> > To: linuxppc-dev@lists.ozlabs.org; netdev@vger.kernel.org; Bucur Madali=\n" - "n-\n" + "> > To: linuxppc-dev@lists.ozlabs.org; netdev@vger.kernel.org; Bucur Madalin-\n" "> > Cristian-B32716\n" "> > Cc: linux-kernel@vger.kernel.org\n" "> > Subject: Re: [PATCH RFC 02/10] dpaa_eth: add support for DPAA Ethernet\n" - "> >=20\n" + "> > \n" "> > On Mon, 2015-07-20 at 09:54 +0200, Joakim Tjernlund wrote:\n" "> > > On Wed, 2015-04-01 at 19:19 +0300, Madalin Bucur wrote:\n" "> > > > This introduces the Freescale Data Path Acceleration Architecture\n" "> > > > (DPAA) Ethernet driver (dpaa_eth) that builds upon the DPAA QMan,\n" "> > > > BMan, PAMU and FMan drivers to deliver Ethernet connectivity on\n" "> > > > the Freescale DPAA QorIQ platforms.\n" - "> > > >=20\n" + "> > > > \n" "> > > > Signed-off-by: Madalin Bucur <madalin.bucur@freescale.com>\n" "> > > > ---\n" "> > > ....\n" "> > > > +\tsnprintf(net_dev->name, IFNAMSIZ, \"fm%d-mac%d\",\n" "> > > > +\t\t dpa_mac_fman_index_get(pdev),\n" "> > > > +\t\t dpa_mac_hw_index_get(pdev));\n" - "> > >=20\n" - "> > > Should ethernet drivers dictate interface name in user space nowadays=\n" - "?\n" + "> > > \n" + "> > > Should ethernet drivers dictate interface name in user space nowadays?\n" "> > > I would prefer if you didn't.\n" - ">=20\n" - "> The preformatted interface name was thought as a helper for quick interfa=\n" - "ce\n" - "> identification. It also ensures constant naming of the interfaces, i.e. i=\n" - "f you\n" + "> \n" + "> The preformatted interface name was thought as a helper for quick interface\n" + "> identification. It also ensures constant naming of the interfaces, i.e. if you\n" "> add/remove PCI network cards. One can make use of udev rules to override\n" "> default interface names (\"eth%d\") in userspace.\n" "\n" - "I am not well versed in ethernet interface naming but I think you are just =\n" - "creating\n" - "another name space here. To me one either have the old eth%d names or let u=\n" - "dev do\n" + "I am not well versed in ethernet interface naming but I think you are just creating\n" + "another name space here. To me one either have the old eth%d names or let udev do\n" "the naming so there is some order w.r.t interface naming.\n" "\n" - "I also find it handy to be able to control which I/F is eth0 etc. just by c=\n" - "hanging\n" - "the order they are listed in the device tree. This makes our application ha=\n" - "ppy :)\n" + "I also find it handy to be able to control which I/F is eth0 etc. just by changing\n" + "the order they are listed in the device tree. This makes our application happy :)\n" "\n" - ">=20\n" - "> Another reason for using this is that the interface name was also used fo=\n" - "r the\n" + "> \n" + "> Another reason for using this is that the interface name was also used for the\n" "> debugfs file name and when compiling dpaa_eth as a module there was a\n" "> problem with udev concurrently renaming interfaces from eth0 to something\n" "> like fmx-macy, making the next probed DPAA interface temporarily get the\n" "> eth0 name (before being renamed fmx-macw). Subsequently,\n" - "> the debugfs_create_file(net_dev->name,...) call failed because of duplica=\n" - "ted\n" + "> the debugfs_create_file(net_dev->name,...) call failed because of duplicated\n" "> names.\n" - ">=20\n" - "> If this is considered more of a bug than a feature, I can remove it and o=\n" - "nly change\n" + "> \n" + "> If this is considered more of a bug than a feature, I can remove it and only change\n" "> the naming of the debugfs entries to avoid the udev issue.\n" "\n" "Perhaps netdev list can advise?\n" "\n" - Jocke= + Jocke -f9c98d068073f1ac7dd22fe79aeb09b5330d5a16aef78a9e9915af44285c2ead +dd88361dc0d040c8b689eff81e5f061b4f4ea139d2fd92f0ae9e3aa400e27be4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.