From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.6 2/3] libxl/psr: use Xen error codes when checking hypercall return values Date: Tue, 21 Jul 2015 14:30:03 +0100 Message-ID: <1437485403.8383.21.camel@citrix.com> References: <1437404102-7807-1-git-send-email-roger.pau@citrix.com> <1437404102-7807-3-git-send-email-roger.pau@citrix.com> <21934.10720.172223.582437@mariner.uk.xensource.com> <21934.11949.408734.564467@mariner.uk.xensource.com> <55AE307D.5080307@citrix.com> <21934.15792.670281.338109@mariner.uk.xensource.com> <1437482822.6323.8.camel@citrix.com> <55AE61B90200007800093A8D@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHXcZ-0004QD-It for xen-devel@lists.xenproject.org; Tue, 21 Jul 2015 13:30:11 +0000 In-Reply-To: <55AE61B90200007800093A8D@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Andrew Cooper , xen-devel@lists.xenproject.org, Wei Liu , Ian Jackson , Roger Pau Monne List-Id: xen-devel@lists.xenproject.org On Tue, 2015-07-21 at 07:14 -0600, Jan Beulich wrote: > > > > > > On 21.07.15 at 14:47, wrote: > > On Tue, 2015-07-21 at 13:40 +0100, Ian Jackson wrote: > > > Andrew Cooper writes ("Re: [Xen-devel] [PATCH for-4.6 2/3] > > > libxl/psr: > > > use Xen error codes when checking hypercall return values"): > > > > EBADSLT isn't the only example here. I believe ENODATA is a > > > > similar > > > > example. > > > > > > http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h. > > > html > > > > > > http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/sys/errno.h?rev=1.40& > > > cont > > > ent-type=text/x-cvsweb-markup&only_with_tag=MAIN > > > > > > But > > > > > > http://fxr.watson.org/fxr/source/sys/errno.h > > > > > > How annoying. > > > > THat's just a FreeBSD bug then? > > Why? The OpenGroup page above clearly says that the two so > far identified values are an extension. I didn't realise that was what the XSR tag meant, sorry. I note that OB is obsolete too FWIW... I suppose it could be worse than "POSIX plus a couple of grandfathered in exceptions (sorry)"... Ian.