From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2] xl: fix vcpus to vnode assignement in config file Date: Tue, 21 Jul 2015 18:30:14 +0200 Message-ID: <1437496214.5036.31.camel@citrix.com> References: <20150720093016.12514.10982.stgit@Solace.station> <1437487998.8383.37.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3915116364024982877==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZHaRA-0001Pl-OB for xen-devel@lists.xenproject.org; Tue, 21 Jul 2015 16:30:36 +0000 In-Reply-To: <1437487998.8383.37.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu List-Id: xen-devel@lists.xenproject.org --===============3915116364024982877== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-3ewRbqUG4klYUpN2hTfg" --=-3ewRbqUG4klYUpN2hTfg Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2015-07-21 at 15:13 +0100, Ian Campbell wrote: > On Mon, 2015-07-20 at 11:30 +0200, Dario Faggioli wrote: > > In fact, right now, if the "vcpus=3D" list (where the > > user specifies what vcpus should be part of a vnode) > > has multiple elements, things don't work. > > E.g., the following examples all result in failure > > to create the guest: >=20 > What is the failure? >=20 With the following configuration: vcpus =3D '4' memory =3D '1024' vnuma =3D [ [ "pnode=3D0","size=3D512","vcpus=3D0,1","vdistances=3D10,20" = ], [ "pnode=3D1","size=3D512","vcpus=3D2,3","vdistances=3D20,10" ] = ] The error message is this one: xl: maxvcpus < vcpus The reason is that, without this change, we only process the first element of the "vcpus=3D" list, i.e., only vcpu 0 (for vnode 0) and vcpu 2 (for vnode 1), up to a total of 2 (rather than 4) vcpus. Basically, things only work if for each vnode, its vcpus are specified by means of a single element. > > Reason is we need either a multidimentional array, > > or a bitmap, to temporary store the vcpus of a > > vnode, while parsing the vnuma config entry. >=20 > That sounds like a cure, not the reason for the failure. Please can you > explain the nature of the failure, so it becomes clear why this change > is needed. >=20 Ok, I'll mention this in here. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-3ewRbqUG4klYUpN2hTfg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlWuc5YACgkQk4XaBE3IOsSJBQCfb9erwHz+JDs3oLuCApvAhhO9 e5kAn1sKA9eZ6+/6I2Cjt5obK12VEzQc =wLnU -----END PGP SIGNATURE----- --=-3ewRbqUG4klYUpN2hTfg-- --===============3915116364024982877== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3915116364024982877==--