From: Axel Lin <axel.lin@ingics.com>
To: Mark Brown <broonie@kernel.org>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org,
Zeng Zhaoming <zengzm.kernel@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Filip Brozovic <fbrozovic@gmail.com>,
Alexander Stein <alexander.stein@systec-electronic.com>
Subject: [PATCH RFT] ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP
Date: Wed, 22 Jul 2015 11:27:45 +0800 [thread overview]
Message-ID: <1437535665.17780.1.camel@ingics.com> (raw)
Currently, below code actually does not update any bit because
SGTL5000_SMALL_POP is 0.
snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL, SGTL5000_SMALL_POP, 1);
The SGTL5000_SMALL_POP should be BIT(0) rather than 0, fix it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi,
I don't have h/w and datasheet, but the code looks obvious does not make
sense. Can someone help to confirm and test if this patch?
Thanks,
Axel
sound/soc/codecs/sgtl5000.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/sgtl5000.h b/sound/soc/codecs/sgtl5000.h
index bd7a344..1c317de 100644
--- a/sound/soc/codecs/sgtl5000.h
+++ b/sound/soc/codecs/sgtl5000.h
@@ -275,7 +275,7 @@
#define SGTL5000_BIAS_CTRL_MASK 0x000e
#define SGTL5000_BIAS_CTRL_SHIFT 1
#define SGTL5000_BIAS_CTRL_WIDTH 3
-#define SGTL5000_SMALL_POP 0
+#define SGTL5000_SMALL_POP 1
/*
* SGTL5000_CHIP_MIC_CTRL
--
2.1.0
next reply other threads:[~2015-07-22 3:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 3:27 Axel Lin [this message]
2015-07-22 8:58 ` [PATCH RFT] ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP Alexander Stein
2015-07-22 9:45 ` Axel Lin
2015-07-22 10:55 ` Fabio Estevam
2015-07-22 9:57 ` Applied "ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP" to the asoc tree Mark Brown
2015-07-22 10:15 ` [PATCH RFT] ASoC: sgtl5000: Fix up define for SGTL5000_SMALL_POP Zeng Zhaoming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437535665.17780.1.camel@ingics.com \
--to=axel.lin@ingics.com \
--cc=alexander.stein@systec-electronic.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=fbrozovic@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=zengzm.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.