From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 6/6] tools/libx{l,
 c}: Fix trivial Coverity defects in migration v2 code
Date: Wed, 22 Jul 2015 11:31:24 +0100
Message-ID: <1437561084.12884.12.camel@citrix.com>
References: <1437388679-16468-1-git-send-email-andrew.cooper3@citrix.com>
	<1437388679-16468-7-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1437388679-16468-7-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-07-20 at 11:37 +0100, Andrew Cooper wrote:
> All of these are UNUSED_VALUE defects where a default vaule is

"value".

> unconditionally overwritten.  They are not particularly interesting,
> bug wise, but keeping these defects at bay helps prevent real bugs
> going unnoticed in the volume.

The flip side is that if the code uses the "init everything and goto
out on error" idiom then the init might need to be put back if the code
changes, hopefully even a regular compiler would spot this though.

> No functional change.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Ian Campbell <Ian.Campbell@citrix.com>