From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-kernel@vger.kernel.org,
Sascha Hauer <kernel@pengutronix.de>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Tero Kristo <t-kristo@ti.com>,
Russell King <linux@arm.linux.org.uk>,
Dinh Nguyen <dinguyen@opensource.altera.com>
Subject: Re: [PATCH v5 2/8] clk: mmp: switch to GENMASK()
Date: Wed, 22 Jul 2015 16:04:05 +0300 [thread overview]
Message-ID: <1437570245.8014.33.camel@linux.intel.com> (raw)
In-Reply-To: <20150721235354.GB15042@codeaurora.org>
On Tue, 2015-07-21 at 16:53 -0700, Stephen Boyd wrote:
> On 07/13, Andy Shevchenko wrote:
> > diff --git a/drivers/clk/mmp/clk.h b/drivers/clk/mmp/clk.h
> > index adf9b71..f5fdb0e 100644
> > --- a/drivers/clk/mmp/clk.h
> > +++ b/drivers/clk/mmp/clk.h
> > @@ -39,7 +39,7 @@ extern struct clk *mmp_clk_register_factor(const
> > char *name,
> >
> > /* Clock type "mix" */
> > #define MMP_CLK_BITS_MASK(width, shift) \
> > - (((1 << (width)) - 1) << (shift))
> > + (GENMASK((width) - 1, 0) << (shift))
>
> This can push the shift into the GENMASK instance too:
Too not optimal. I checked the assembly.
>
> (GENMASK((width) - 1 + (shift), (shift))
>
> > #define MMP_CLK_BITS_GET_VAL(data, width, shift) \
> > ((data & MMP_CLK_BITS_MASK(width, shift)) >>
> > (shift))
> > #define MMP_CLK_BITS_SET_VAL(val, width, shift) \
> > --
> > 2.1.4
> >
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2015-07-22 13:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 14:07 [PATCH v5 0/8] clk: replace div_mask() by GENMASK() Andy Shevchenko
2015-07-13 14:07 ` [PATCH v5 1/8] clk: divider: switch to GENMASK() Andy Shevchenko
2015-07-21 23:48 ` Stephen Boyd
2015-07-22 13:03 ` Andy Shevchenko
2015-07-13 14:07 ` [PATCH v5 2/8] clk: mmp: " Andy Shevchenko
2015-07-21 23:53 ` Stephen Boyd
2015-07-22 13:04 ` Andy Shevchenko [this message]
2015-07-13 14:07 ` [PATCH v5 3/8] clk: socfpga: " Andy Shevchenko
2015-07-13 15:48 ` Dinh Nguyen
2015-07-22 0:00 ` Stephen Boyd
2015-07-13 14:07 ` [PATCH v5 4/8] clk: ti: divider: " Andy Shevchenko
2015-07-13 14:07 ` [PATCH v5 5/8] clk: tegra: " Andy Shevchenko
2015-07-13 14:07 ` [PATCH v5 6/8] clk: hisilicon: " Andy Shevchenko
2015-07-13 14:07 ` [PATCH v5 7/8] clk: bcm: " Andy Shevchenko
2015-07-13 14:07 ` [PATCH v5 8/8] ARM: imx: " Andy Shevchenko
2015-10-09 15:41 ` [PATCH v5 0/8] clk: replace div_mask() by GENMASK() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437570245.8014.33.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dinguyen@opensource.altera.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pdeschrijver@nvidia.com \
--cc=sboyd@codeaurora.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.