From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v12] introduce
	XENMEM_reserved_device_memory_map
Date: Wed, 22 Jul 2015 14:46:02 +0100
Message-ID: <1437572762.19412.3.camel@citrix.com>
References: <1437528607-19315-1-git-send-email-tiejun.chen@intel.com>
	<1437528607-19315-2-git-send-email-tiejun.chen@intel.com>
	<55AF8F9B0200007800093F69@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55AF8F9B0200007800093F69@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Tiejun Chen <tiejun.chen@intel.com>, xen-devel@lists.xen.org
Cc: Yang Z Zhang <yang.z.zhang@intel.com>, Keir Fraser <keir@xen.org>, Kevin Tian <kevin.tian@intel.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-07-22 at 04:42 -0600, Jan Beulich wrote:
> This is a prerequisite for punching holes into HVM and PVH guests' 
> P2M
> to allow passing through devices that are associated with (on VT-d)
> RMRRs.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
> Acked-by: Kevin Tian <kevin.tian@intel.com>

You explained on IRC that you had misinterpreted Daniel's response
about XSM and in fact such a check is not needed.

So I think the only pending changes are to move the union to the end of
xen_reserved_device_memory_map and to move the entire interface
definition under a #if defined(__XEN__) || defined(__XEN_TOOLS__).

All of the actual code here looks good to me and with those two changes
I would:
    Acked-by: Ian Campbell <ian.campbell@citrix.com>

Ian.