From: Ian Campbell <ian.campbell@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>,
xen-devel@lists.xenproject.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v3] xl: fix vcpus to vnode assignement in config file
Date: Wed, 22 Jul 2015 15:55:35 +0100 [thread overview]
Message-ID: <1437576935.19412.10.camel@citrix.com> (raw)
In-Reply-To: <20150721173156.28189.35543.stgit@Solace.station>
On Tue, 2015-07-21 at 19:31 +0200, Dario Faggioli wrote:
> In fact, right now, the following (legitimate)
> configuration:
>
> vcpus = '4'
> vnuma = [ [ "pnode=0","size=512","vcpus=0,1","vdistances=10,20" ],
> [ "pnode=1","size=512","vcpus=2,3","vdistances=20,10" ] ]
>
> Produces the following error:
>
> # xl create /etc/xen/test.cfg
> Parsing config from /etc/xen/test.cfg
> xl: maxvcpus < vcpu
>
> That is because, we only process the first element of the
> "vcpus=" list (of each vnode specification). Therefore,
> in the above case, we only see 2 vcpus, out of 4, being
> assigned to the vnodes, and hence the error.
>
> What we need is either a multidimentional array, or a
> bitmap, to temporary store the vcpus of a vnode, while
> parsing the vnuma config entry. Let's use the latter,
> which happens to also make it easier to copy the outcome
> of the parsing to its final destination in b_info, if
> everything goes ok.
>
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
Applied, thanks.
prev parent reply other threads:[~2015-07-22 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 17:31 [PATCH v3] xl: fix vcpus to vnode assignement in config file Dario Faggioli
2015-07-22 14:55 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437576935.19412.10.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.