From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] hvmloader: don't build with __XEN_TOOLS__
 defined
Date: Thu, 23 Jul 2015 09:10:14 +0100
Message-ID: <1437639014.19412.14.camel@citrix.com>
References: <55AFC6E902000078000941D2@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=639e45c83=Ian.Campbell@citrix.com>)
	id 1ZIBa7-0007Nd-Re
	for xen-devel@lists.xenproject.org; Thu, 23 Jul 2015 08:10:19 +0000
In-Reply-To: <55AFC6E902000078000941D2@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-07-22 at 08:38 -0600, Jan Beulich wrote:
> This being an in-guest component, it shouldn't get to see (and even
> less so use) tools-only public interfaces.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

FWIW: Acked-by: Ian Campbell <ian.campbell@citrix.com>

> 
> --- a/tools/firmware/hvmloader/Makefile
> +++ b/tools/firmware/hvmloader/Makefile
> @@ -31,6 +31,9 @@ SMBIOS_REL_DATE ?= $(shell date +%m/%d/%
>  
>  CFLAGS += $(CFLAGS_xeninclude)
>  
> +# We mustn't use tools-only public interfaces.
> +CFLAGS += -U__XEN_TOOLS__ 
> -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__
> +
>  OBJS  = hvmloader.o mp_tables.o util.o smbios.o 
>  OBJS += smp.o cacheattr.o xenbus.o vnuma.o
>  OBJS += e820.o pci.o pir.o ctype.o
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel