From: Ian Campbell <ian.campbell@citrix.com>
To: Jonathan Creekmore <jonathan.creekmore@gmail.com>,
xen-devel@lists.xenproject.org
Cc: dave.scott@eu.citrix.com
Subject: Re: [PATCH v2] oxenstored: link in the systemd system library
Date: Thu, 23 Jul 2015 15:00:13 +0100 [thread overview]
Message-ID: <1437660013.24746.0.camel@citrix.com> (raw)
In-Reply-To: <1437658839-10478-1-git-send-email-jonathan.creekmore@gmail.com>
On Thu, 2015-07-23 at 08:40 -0500, Jonathan Creekmore wrote:
> If systemd is configured for use AND you are building oxenstored, the
> C
> systemd library must be linked in to the systemd.cxma library.
>
> Signed-off-by: Jonathan Creekmore <jonathan.creekmore@gmail.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
OOI what was the failure mode for you without this? Runtime rather than
build time I suspect?
> ---
> Changed since v1:
> * Link the systemd library in to the systemd.cxma instead of the
> final
> binary.
> ---
> tools/ocaml/xenstored/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/ocaml/xenstored/Makefile
> b/tools/ocaml/xenstored/Makefile
> index d861f11..59875f7 100644
> --- a/tools/ocaml/xenstored/Makefile
> +++ b/tools/ocaml/xenstored/Makefile
> @@ -30,6 +30,8 @@ systemd_OBJS = systemd
> systemd_C_OBJS = systemd_stubs
> OCAML_LIBRARY += systemd
>
> +LIBS_systemd += $(LDFLAGS-y)
> +
> OBJS = define \
> stdext \
> trie \
next prev parent reply other threads:[~2015-07-23 14:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 22:02 [PATCH] oxenstored: link in the systemd system library Jonathan Creekmore
2015-07-23 8:41 ` Ian Campbell
2015-07-23 13:40 ` [PATCH v2] " Jonathan Creekmore
2015-07-23 14:00 ` Ian Campbell [this message]
2015-07-23 14:03 ` Jonathan Creekmore
2015-07-23 14:06 ` Ian Campbell
2015-07-24 11:04 ` Ian Campbell
2015-07-23 9:02 ` [PATCH] " Dave Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437660013.24746.0.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=dave.scott@eu.citrix.com \
--cc=jonathan.creekmore@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.