From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v3 05/13] toolstack: distinguish
 local and remote migration support
Date: Thu, 23 Jul 2015 17:15:18 +0100
Message-ID: <1437668118.24746.18.camel@citrix.com>
References: <1437560015-4999-1-git-send-email-wei.liu2@citrix.com>
	<1437560015-4999-6-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=639e45c83=Ian.Campbell@citrix.com>)
	id 1ZIJ9b-0005HS-4w
	for xen-devel@lists.xenproject.org; Thu, 23 Jul 2015 16:15:27 +0000
In-Reply-To: <1437560015-4999-6-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Cc: ian.jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-07-22 at 11:13 +0100, Wei Liu wrote:
> 
> +# Mode should be either 1 ("local") or 0 ("remote")
> +our ($whhost, $gn, $mode) = @ARGV;

I think $mode would be better given a more "boolean" name, in this case
$local.

However that's a minor nit so with or without that changed:

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Ian.