From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v3 01/13] toolstack: save / restore
	check
Date: Fri, 24 Jul 2015 09:54:16 +0100
Message-ID: <1437728056.24746.34.camel@citrix.com>
References: <1437560015-4999-1-git-send-email-wei.liu2@citrix.com>
	<1437560015-4999-2-git-send-email-wei.liu2@citrix.com>
	<1437668205.24746.20.camel@citrix.com>
	<20150723164537.GF12377@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6401e7af6=Ian.Campbell@citrix.com>)
	id 1ZIYkI-00085Y-2S
	for xen-devel@lists.xenproject.org; Fri, 24 Jul 2015 08:54:22 +0000
In-Reply-To: <20150723164537.GF12377@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, ian.jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-07-23 at 17:45 +0100, Wei Liu wrote:
> On Thu, Jul 23, 2015 at 05:16:45PM +0100, Ian Campbell wrote:
> > On Wed, 2015-07-22 at 11:13 +0100, Wei Liu wrote:
> > > +++ b/Osstest/Toolstack/libvirt.pm
> > > [...]
> > > +sub saverestore_check ($) {
> > > +    my ($self) = @_;
> > > +    return check_for_command($self, "save");
> > 
> > I just noticed that in a later patch you parse the capabilities xml 
> > to
> > check for migration support. Is save/restore reflected there too?
> > Parsing structured output from a command designed to produce 
> > machine
> > readable output out to be preferred to parsing help output if 
> > possible.
> > 
> 
> Anthony helped me check that. The ability to save and restore is not
> reflected in xml output of "virsh capabilities".

Thanks for checking, in that case we should do as you have done (i.e.
my ack stands).

Ian.