From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] xen: arm: Document xenheap_megabytes limitation Date: Fri, 24 Jul 2015 12:05:18 +0100 Message-ID: <1437735918.24746.65.camel@citrix.com> References: <4EE5B48738DDED408878C97C8E050A8B1D7D96EB@SJEXCHMB05.corp.ad.broadcom.com> <55B11B1D.1070608@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55B11B1D.1070608@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , "Chris (Christopher) Brand" , "xen-devel@lists.xen.org" Cc: Ian Jackson , Keir Fraser , Jan Beulich , Tim Deegan List-Id: xen-devel@lists.xenproject.org On Thu, 2015-07-23 at 17:49 +0100, Julien Grall wrote: > Hi Chris, > > Thank you for patch. > > On 23/07/15 17:31, Chris (Christopher) Brand wrote: > > In setup_mm(), the value passed as xenheap_megabytes gets > > converted to pages and passed to setup_xenheap_mappings(), > > which in turn passes it to create_32mb_mappings(), which > > contains an ASSERT that the value passed is a multiple of > > 32MB. So specifying any value that is not an integer multiple > > of 32 will cause Xen to hit this assert and fail to boot. > > > > Signed-off-by: Chris Brand > > I wondering if it would worth to add a check in the code to ensure > that > it's a multiple of 32MB? Arguably we have that in the form of the assert/panic, but perhaps there should be a nicer message. > Nonetheless: > > Reviewed-by: Julien Grall Acked + applied.