From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel@lists.xensource.com, Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH 4/5] xl: Command line: Make COMMON_LONG_OPTS include sentinel
Date: Fri, 24 Jul 2015 12:06:21 +0100 [thread overview]
Message-ID: <1437735981.24746.67.camel@citrix.com> (raw)
In-Reply-To: <21929.14157.992698.85181@mariner.uk.xensource.com>
On Fri, 2015-07-17 at 18:11 +0100, Ian Jackson wrote:
> Andrew Cooper writes ("Re: [Xen-devel] [PATCH 4/5] xl: Command line:
> Make COMMON_LONG_OPTS include sentinel"):
> > On 17/07/15 18:00, Ian Jackson wrote:
> > > No functional change.
>
> > Perhaps a comment stating that COMMON_LONG_OPTS must now be the
> > final
> > entry in an option list? Previously it was technically able to
> > live
> > anywhere in the list.
>
> Sure.
I applied and inserted:
/* Must be last in list */
before the #define
I also picked up the last patch.
next prev parent reply other threads:[~2015-07-24 11:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 17:00 [PATCH 1/5] xl: Command line: Adjust "Fix segfaults from `xl psr-cat-cbm-set`..." Ian Jackson
2015-07-17 17:00 ` [PATCH 2/5] xl: Command line: Remove maximum argument limit for network-attach Ian Jackson
2015-07-20 10:00 ` Wei Liu
2015-07-17 17:00 ` [PATCH 3/5] xl: Command line: Support -h everywhere Ian Jackson
2015-07-20 10:06 ` Wei Liu
2015-07-17 17:00 ` [PATCH 4/5] xl: Command line: Make COMMON_LONG_OPTS include sentinel Ian Jackson
2015-07-17 17:09 ` Andrew Cooper
2015-07-17 17:11 ` Ian Jackson
2015-07-24 11:06 ` Ian Campbell [this message]
2015-07-17 17:00 ` [PATCH 5/5] xl: Command line: Support xl vcpu-set --help Ian Jackson
2015-07-20 10:07 ` Wei Liu
2015-07-17 17:04 ` [PATCH 1/5] xl: Command line: Adjust "Fix segfaults from `xl psr-cat-cbm-set`..." Andrew Cooper
2015-07-21 14:16 ` Ian Campbell
2015-07-21 14:27 ` Ian Jackson
2015-07-21 14:36 ` Wei Liu
2015-07-21 15:26 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437735981.24746.67.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.