From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Tiejun Chen <tiejun.chen@intel.com>,
ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] tools: libxl: Use correct printf format for uint64_t
Date: Fri, 24 Jul 2015 12:08:12 +0100 [thread overview]
Message-ID: <1437736092.24746.69.camel@citrix.com> (raw)
In-Reply-To: <20150724104242.GD30594@zion.uk.xensource.com>
On Fri, 2015-07-24 at 11:42 +0100, Wei Liu wrote:
> On Fri, Jul 24, 2015 at 11:41:17AM +0100, Ian Campbell wrote:
> > Since 25652f232cbe "tools/libxl: detect and avoid conflicts with
> > RDM"
> > the build is broken for x86_32 and arm32 with:
> >
> > libxl_dm.c: In function ‘libxl__domain_device_construct_rdm’:
> > libxl_dm.c:349:13: error: format ‘%lx’ expects argument of type
> > ‘long unsigned int’, but argument 8 has type ‘uint64_t’ [
> > -Werror=format=]
> > LOG(ERROR, "RDM conflict at 0x%lx.\n", d_config
> > ->rdms[i].start);
> > ^
> > libxl_dm.c:352:13: error: format ‘%lx’ expects argument of type
> > ‘long unsigned int’, but argument 8 has type ‘uint64_t’ [
> > -Werror=format=]
> > LOG(WARN, "Ignoring RDM conflict at 0x%lx.\n",
> >
> > Use PRIx64 for these.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > Cc: Tiejun Chen <tiejun.chen@intel.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
Applied, thanks.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2015-07-24 11:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 10:41 [PATCH] tools: libxl: Use correct printf format for uint64_t Ian Campbell
2015-07-24 10:42 ` Ian Jackson
2015-07-24 10:42 ` Wei Liu
2015-07-24 11:08 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437736092.24746.69.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=tiejun.chen@intel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.