From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST PATCH 08/10] cs-bisection-step: Fix
 memoisation of search_compute_length_at
Date: Fri, 24 Jul 2015 12:09:10 +0100
Message-ID: <1437736150.24746.70.camel@citrix.com>
References: <1437675564-16602-1-git-send-email-ian.jackson@eu.citrix.com>
	<1437675564-16602-9-git-send-email-ian.jackson@eu.citrix.com>
	<1437729981.24746.51.camel@citrix.com>
	<21938.6663.980409.738978@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=6401e7af6=Ian.Campbell@citrix.com>)
	id 1ZIaqq-0002G7-1o
	for xen-devel@lists.xenproject.org; Fri, 24 Jul 2015 11:09:16 +0000
In-Reply-To: <21938.6663.980409.738978@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-07-24 at 11:57 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [OSSTEST PATCH 08/10] cs-bisection-step: 
> Fix memoisation of search_compute_length_at"):
> > On Thu, 2015-07-23 at 19:19 +0100, Ian Jackson wrote:
> > > There was a half-implemented memoisation.  Memoisation is 
> > > necessary
> > > because otherwise the algorithm is exponential in the commit 
> > > history
> > > depth (with base equal to the commit parent fanout).
> > > 
> > > Sort this out:
> > >  * Break out the actual computation into a ne
> > >    search_compute_length_at_intern
> > 
> > Some stray characters here?
> 
> Just a missing `w', fixed.
> 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Thanks.
> 
> .oO{ git-filter-brach --msg-filter 'cat; echo "Acked-by"' }

$ cat /home/ianc/git-ack-branch
#!/bin/bash

set -ex

: ${BY:=Acked-by: Ian Campbell <ian.campbell@citrix.com>}

git filter-branch  -f --msg-filter "cat ; echo \"${BY}\"" $@
$