From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST] standalone: Extend -h to support ident=host style specifications Date: Fri, 24 Jul 2015 14:51:19 +0100 Message-ID: <1437745879.24746.107.camel@citrix.com> References: <1437742602-25990-1-git-send-email-ian.campbell@citrix.com> <21938.16559.397508.847055@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21938.16559.397508.847055@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, 2015-07-24 at 14:42 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST] standalone: Extend -h to support > ident=host style specifications"): > > Allowing for multi-host tests. > ... > > job=$1; shift > > - ./cs-adjust-flight -v $flight runvar-del $job host > > + ./cs-adjust-flight -v $flight runvar-del $job '/host$' > > This regexp is slightly wrong because host runvars are all > (?:\w+_)?host$ I'll update. > > + hosts="$ident=$h $hosts" > > Any reason you push it on the front rather than adding it to the end ? So that it matches the order of the arguments. Which matters for the run -test case. At least it did for ts-guest-nbd-mirror which wants to be given $srvhost $clthost in that order. > It _shouldn't_ matter, but what if someone specifies -h foo=X -h foo=Y ? For run-test ts-* will get foo=X foo=Y on the command line. For run-job OSSTEST_HOST_FOO=X will prevail. Perhaps export_hosts_environ should process the list in $hosts in reverse? I think that gets best of both worlds? Ian.