From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST] Arrange to test migration from the
 previous Xen version
Date: Fri, 24 Jul 2015 15:03:21 +0100
Message-ID: <1437746601.24746.114.camel@citrix.com>
References: <1437744312-30373-1-git-send-email-ian.campbell@citrix.com>
	<21938.17337.240136.22359@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21938.17337.240136.22359@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-07-24 at 14:55 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST] Arrange to test migration from the 
> previous Xen version"):
> > There are several steps to this:
> 
> Thanks.  Much of this is very elegant.

Thank you, the building blocks are very flexible!

> > +select_prevxenbranch () {
> > +	local b
> > +	local p
> > +	for b in $(./mg-list-all-branches) ; do # already sorted by 
> > version
> > +		case "$b" in
> > +		xen*)
> 
> Maybe these patterns should be "xen-" ?  In case someone invents a
> tree `xenblargle'.
> 
> Hrm, I see you took the example of ap-print-url, cri-common and
> mfi-common.

Shall I get out my yakk scissors?

> > +        # XXX could find latest pass on that branch and attempt to 
> > reuse.
> > +        #bfiprevxen=...
> 
> There is some nascent stuff in my smoke branch which might help with
> this.  It's not suitable for public consumption.

I think we could do without it for now?

> > +        # To avoid the need for TREE_PREVQEMU, TREE_PREVOVMF etc we
> > +        # only pass tree_xen and revision_xen here and therefore
> > +        # pickup the versions implicitly selected by the
> > +        # $REVISION_PREVXEN.
> > +        #
> > +        # XXX I think this doesn't break bisecting over the old
> > +        # versions, since the bisectory will set tree_* based on what
> > +        # was actually built, not based on this set of vars.
> 
> You are correct.

Super. I shall s/XXX I think t/T/ in the next version. Or shall I drop the
paragraph?

I'll fix "bisectory" too

Ian.