From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Sender: Rob Herring From: Rob Herring To: Mike Turquette , Stephen Boyd Cc: Thomas Gleixner , linux-clk@vger.kernel.org Subject: [PATCH v3] clk: kill off set_irq_flags usage Date: Mon, 27 Jul 2015 15:55:14 -0500 Message-Id: <1438030523-15853-2-git-send-email-robh@kernel.org> In-Reply-To: <1438030523-15853-1-git-send-email-robh@kernel.org> References: <1438030523-15853-1-git-send-email-robh@kernel.org> List-ID: set_irq_flags is ARM specific with custom flags which have genirq equivalents. Convert drivers to use the genirq interfaces directly, so we can kill off set_irq_flags. The translation of flags is as follows: IRQF_VALID -> !IRQ_NOREQUEST IRQF_PROBE -> !IRQ_NOPROBE IRQF_NOAUTOEN -> IRQ_NOAUTOEN For IRQs managed by an irqdomain, the irqdomain core code handles clearing and setting IRQ_NOREQUEST already, so there is no need to do this in .map() functions and we can simply remove the set_irq_flags calls. Some users also modify IRQ_NOPROBE and this has been maintained although it is not clear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring Acked-by: Boris Brezillon Cc: Mike Turquette Acked-by: Stephen Boyd Cc: linux-clk@vger.kernel.org --- Thomas asked that this be merged thru subsystem trees instead of arm-soc, so please apply this to your tree. Rob drivers/clk/at91/pmc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c index 39be2be..d1844f1 100644 --- a/drivers/clk/at91/pmc.c +++ b/drivers/clk/at91/pmc.c @@ -125,7 +125,6 @@ static int pmc_irq_map(struct irq_domain *h, unsigned int virq, irq_set_chip_and_handler(virq, &pmc_irq, handle_level_irq); - set_irq_flags(virq, IRQF_VALID); irq_set_chip_data(virq, pmc); return 0; -- 2.1.0