From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>,
linux-leds@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
j.anaszewski@samsung.com, mpe@ellerman.id.au, rpurdie@rpsys.net,
cooloney@gmail.com, khandual@linux.vnet.ibm.com,
j.anaszewski81@gmail.com, arnd@arndb.de,
stewart@linux.vnet.ibm.com
Subject: Re: [PATCH v8 3/3] leds/powernv: Add driver for PowerNV platform
Date: Tue, 28 Jul 2015 20:14:55 +1000 [thread overview]
Message-ID: <1438078495.7562.135.camel@kernel.crashing.org> (raw)
In-Reply-To: <55B72369.5040102@gmail.com>
On Tue, 2015-07-28 at 08:38 +0200, Jacek Anaszewski wrote:
> >>> + /* Register the classdev */
> >>> + rc = devm_led_classdev_register(dev, &powernv_led->cdev);
> >>> + if (rc) {
> >>> + dev_err(dev, "%s: Classdev registration failed for %s\n",
> >>> + __func__, powernv_led->cdev.name);
> >>> + }
>
> Braces are not needed here,
Putting my old maintainer hat on for a minute ... this is serious nit
picking :-)
Arguably, the function being multi-line, the braces do make the code
more readable. This is a matter of taste which in such as case
which isn't a blatant violation of an important rule should be left to
the choice of the code implementor/maintainer.
Cheers,
Ben.
next prev parent reply other threads:[~2015-07-28 10:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-25 5:21 [PATCH v8 0/3] LED driver for PowerNV platform Vasant Hegde
2015-07-25 5:21 ` [PATCH v8 1/3] powerpc/powernv: Add OPAL interfaces for accessing and modifying system LED states Vasant Hegde
2015-07-25 5:21 ` [PATCH v8 2/3] powerpc/powernv: Create LED platform device Vasant Hegde
2015-07-25 5:21 ` [PATCH v8 3/3] leds/powernv: Add driver for PowerNV platform Vasant Hegde
2015-07-26 21:41 ` Jacek Anaszewski
2015-07-27 3:41 ` Vasant Hegde
2015-07-27 9:50 ` Jacek Anaszewski
2015-07-28 13:40 ` Vasant Hegde
2015-07-28 17:40 ` Jacek Anaszewski
2015-08-19 11:54 ` Jacek Anaszewski
2015-08-19 12:06 ` Vasant Hegde
2015-07-28 6:38 ` Jacek Anaszewski
2015-07-28 10:14 ` Benjamin Herrenschmidt [this message]
2015-07-28 11:23 ` Jacek Anaszewski
2015-08-18 10:21 ` [v8,3/3] " Michael Ellerman
2015-08-18 10:21 ` Michael Ellerman
2015-08-19 8:42 ` Vasant Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438078495.7562.135.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=arnd@arndb.de \
--cc=cooloney@gmail.com \
--cc=hegdevasant@linux.vnet.ibm.com \
--cc=j.anaszewski81@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=jacek.anaszewski@gmail.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-leds@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=rpurdie@rpsys.net \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.