From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 1/4] libxl: CODING_STYLE: Much new material
Date: Tue, 28 Jul 2015 11:25:13 +0100
Message-ID: <1438079113.11600.113.camel@citrix.com>
References: <1415198630-29937-1-git-send-email-ian.jackson@eu.citrix.com>
	<1415198630-29937-2-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1415198630-29937-2-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xensource.com
Cc: stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-11-05 at 14:43 +0000, Ian Jackson wrote:

Sorry to be a bit late to the game, do I win a prize? ;-)

[...]
> + Usually, don't use:     Instead, use (see libxl_internal.h):
> +  libxl__log[v]           LOG, LOGE, LOGEV
> +  libxl__sprintf          GCSPRINTF
> +  libxl__*alloc et al.    GCNEW, GCNEW_ARRAY, GCREALLOC_ARRAY
> +  malloc et al.           GCNEW, GCNEW_ARRAY, GCREALLOC_ARRAY with NOGC

This last one isn't possible, because those macros do not take an explicit
gc (they assume gc in the calling context) so you can't pass them NOGC.

Ian.