All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olof Johansson <olof.johansson@axis.com>
To: Peter Urbanec <openembedded-devel@urbanec.net>,
	<bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH] wget.py: support for semi-colons in URL
Date: Tue, 28 Jul 2015 12:57:16 +0200	[thread overview]
Message-ID: <1438080227-sup-10@axis.com> (raw)
In-Reply-To: <55B71765.6070901@urbanec.net>

Excerpts from Peter Urbanec's message of 2015-07-28 07:47:17 +0200:
> I have not examined the code, but could the URL use the standard URL 
> encoding mechanism to represent ; as %3B ?
> 
> The idea being that the initial "Bitbake URL" is parsed / split using 
> the original string with semicolons and the URL escaped semicolon is 
> passed through to a lower layer that uses that part of the string as an 
> "Internet URL"

URI encoded enitities today are handled correctly in my opinion. If I
have a filename including a ;, I don't want it to be parsed as part of
the URL, neither by bitbake nor the remote server --- that's where URI
encoding comes in.

By hijacking URI encoding to mean "part of the URI, not parsed by
bitbake", you will suprise users that expect it to mean "URI data, not
URI control character" if I understand your proposal correctly.

That could be solved by double encoding, but I don't think that would be
worth it, all occurences of URI encoding in SRC_URI today would have to
be updated. E.g. %20 -> %2520.

-- 
olof johansson


  reply	other threads:[~2015-07-28 10:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-25 18:32 [PATCH] wget.py: support for semi-colons in URL Juro Bystricky
2015-07-25 19:14 ` Christopher Larson
2015-07-27 16:10   ` Bystricky, Juro
2015-07-27 17:58     ` Christopher Larson
2015-07-27 20:01       ` Richard Purdie
2015-07-28  5:47     ` Peter Urbanec
2015-07-28 10:57       ` Olof Johansson [this message]
2015-07-28 11:00 ` Olof Johansson
2015-07-28 16:06   ` Bystricky, Juro
2015-07-28 19:38     ` Richard Purdie
2015-07-29 18:12       ` Bystricky, Juro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438080227-sup-10@axis.com \
    --to=olof.johansson@axis.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=openembedded-devel@urbanec.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.