From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.6 v2 8/8] libxl: remove dead code libxl__domain_shutdown_reason Date: Tue, 28 Jul 2015 11:52:24 +0100 Message-ID: <1438080744.11600.127.camel@citrix.com> References: <1438019109-31997-1-git-send-email-wei.liu2@citrix.com> <1438019109-31997-9-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZK2Uo-0002uB-4I for xen-devel@lists.xenproject.org; Tue, 28 Jul 2015 10:52:30 +0000 In-Reply-To: <1438019109-31997-9-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , Xen-devel Cc: Ian Jackson List-Id: xen-devel@lists.xenproject.org On Mon, 2015-07-27 at 18:45 +0100, Wei Liu wrote: > There is no user in tree. git log -S libxl__domain_shutdown_reason git log -S get_shutdown_reason (the later being a rename that the former picks up on) suggests it has _never_ been used! > Signed-off-by: Wei Liu Acked-by: Ian Campbell > --- > tools/libxl/libxl_dom.c | 17 ----------------- > tools/libxl/libxl_internal.h | 1 - > 2 files changed, 18 deletions(-) > > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c > index b3ae5b5..5555fea 100644 > --- a/tools/libxl/libxl_dom.c > +++ b/tools/libxl/libxl_dom.c > @@ -42,23 +42,6 @@ libxl_domain_type libxl__domain_type(libxl__gc *gc, > uint32_t domid) > return LIBXL_DOMAIN_TYPE_PV; > } > > -int libxl__domain_shutdown_reason(libxl__gc *gc, uint32_t domid) > -{ > - libxl_ctx *ctx = libxl__gc_owner(gc); > - xc_domaininfo_t info; > - int ret; > - > - ret = xc_domain_getinfolist(ctx->xch, domid, 1, &info); > - if (ret != 1) > - return -1; > - if (info.domain != domid) > - return -1; > - if (!(info.flags & XEN_DOMINF_shutdown)) > - return -1; > - > - return (info.flags >> XEN_DOMINF_shutdownshift) & > XEN_DOMINF_shutdownmask; > -} > - > int libxl__domain_cpupool(libxl__gc *gc, uint32_t domid) > { > xc_domaininfo_t info; > diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h > index f2466dc..c7e4709 100644 > --- a/tools/libxl/libxl_internal.h > +++ b/tools/libxl/libxl_internal.h > @@ -1042,7 +1042,6 @@ _hidden int > libxl__file_reference_unmap(libxl__file_reference *f); > > /* from xl_dom */ > _hidden libxl_domain_type libxl__domain_type(libxl__gc *gc, uint32_t > domid); > -_hidden int libxl__domain_shutdown_reason(libxl__gc *gc, uint32_t > domid); > _hidden int libxl__domain_cpupool(libxl__gc *gc, uint32_t domid); > _hidden libxl_scheduler libxl__domain_scheduler(libxl__gc *gc, uint32_t > domid); > _hidden int libxl__sched_set_params(libxl__gc *gc, uint32_t domid,