All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pawel Moll <pawel.moll@arm.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf tests: Adding build test for having ending slash in double slash
Date: Tue, 28 Jul 2015 13:40:52 +0100	[thread overview]
Message-ID: <1438087252.2114.15.camel@arm.com> (raw)
In-Reply-To: <20150727182417.GD20509@krava.brq.redhat.com>

On Mon, 2015-07-27 at 19:24 +0100, Jiri Olsa wrote:
> I'm getting install error with your patch:
> 
> [jolsa@krava perf]$ rm -rf /tmp/krava/ && make install prefix=/tmp/krava
> 
> SNIP
> 
>   LINK     perf
>   INSTALL  binaries
>   INSTALL  tests
> install: cannot create directory ‘’: No such file or directory
> install: target ‘’ is not a directory: No such file or directory
> ln: failed to access ‘/perf’: No such file or directory
> Makefile.perf:492: recipe for target 'install-tools' failed
> make[1]: *** [install-tools] Error 1
> make[1]: *** Waiting for unfinished jobs....
> Makefile:87: recipe for target 'install' failed
> make: *** [install] Error 2
> 
> somethings wrong with install targets dealing with bindir_SQ

Interesting. Building from a perf-tar-src-pkg tarball works:

$ rm -rf /tmp/krava/ && make install prefix=/tmp/krava
[...]
  LINK     perf
  LINK     libperf-gtk.so
  INSTALL  GTK UI
  INSTALL  binaries
  INSTALL  tests
  INSTALL  libexec
  INSTALL  perf-archive
  INSTALL  perf-with-kcore
  INSTALL  perl-scripts
  INSTALL  python-scripts
  INSTALL  perf_completion-script

but it breaks indeed the way you pointed out when building in-tree...

Having a look now.

Pawel


  reply	other threads:[~2015-07-28 12:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 16:46 [PATCH] tools: perf: Fix test build error when bindir contains double slash Pawel Moll
2015-07-27 18:24 ` [PATCH] perf tests: Adding build test for having ending slash in " Jiri Olsa
2015-07-28 12:40   ` Pawel Moll [this message]
2015-07-28 13:44     ` Pawel Moll
2015-07-31 13:55   ` [tip:perf/core] perf tests: Adding build test for having ending " tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438087252.2114.15.camel@arm.com \
    --to=pawel.moll@arm.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.