From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v5 01/22] xen/arm: Return success if dt node
 does not have irq mapping
Date: Tue, 28 Jul 2015 14:23:41 +0100
Message-ID: <1438089821.11600.153.camel@citrix.com>
References: <1437995524-19772-1-git-send-email-vijay.kilari@gmail.com>
	<1437995524-19772-2-git-send-email-vijay.kilari@gmail.com>
	<55B77FF0.3010709@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <55B77FF0.3010709@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>, vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com, stefano.stabellini@citrix.com, tim@xen.org, xen-devel@lists.xen.org
Cc: Prasun.Kapoor@caviumnetworks.com, manish.jaggi@caviumnetworks.com, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-07-28 at 14:13 +0100, Julien Grall wrote:
> Hi Vijay,
> 
> I think the title is too wide for the patch. I would rename to
> "xen/dt: Handle correctly node with interrupt-map in dt_for_each_irq_map"
> 
> On 27/07/15 12:11, vijay.kilari@gmail.com wrote:
> > From: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> > 
> > dt_for_each_irq_map() returns error if no irq mapping is found.
> > With this patch, Ignore error and return success
> > 
> > Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>
> 
> I think this would be a bug fix for Xen 4.6. Can you send it separately?

I'm happy to be pointed at subsets of a series which are suitable to go in
now, no particular need to resend separately, assuming it can be applied in
isolation.

> 
> > ---
> >  xen/common/device_tree.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> > index 323c3be..1325ad5 100644
> > --- a/xen/common/device_tree.c
> > +++ b/xen/common/device_tree.c
> > @@ -1085,7 +1085,7 @@ int dt_for_each_irq_map(const struct 
> > dt_device_node *dev,
> >      if ( imap == NULL )
> >      {
> >          dt_dprintk(" -> no map, ignoring\n");
> > -        goto fail;
> > +        return 0;
> >      }
> 
> At the same time, can you also fix the comment above the if (i.e "/* No
> interrupt map, check for an interrupt parent */") which is wrong?
> 
> >      imaplen /= sizeof(u32);
> >  
> > 
> 
> Regards,
>