From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ander Conselvan De Oliveira Subject: Re: [PATCH v2 06/12] drm/i915: Make crtc checking use the atomic state. Date: Wed, 29 Jul 2015 15:31:50 +0300 Message-ID: <1438173110.3839.9.camel@gmail.com> References: <1438000541-3219-1-git-send-email-maarten.lankhorst@linux.intel.com> <1438000541-3219-7-git-send-email-maarten.lankhorst@linux.intel.com> <1438170585.3839.8.camel@gmail.com> <20150729120413.GV16722@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 23B596E50A for ; Wed, 29 Jul 2015 05:31:56 -0700 (PDT) Received: by pachj5 with SMTP id hj5so5099675pac.3 for ; Wed, 29 Jul 2015 05:31:55 -0700 (PDT) In-Reply-To: <20150729120413.GV16722@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE1LTA3LTI5IGF0IDE0OjA0ICswMjAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ IE9uIFdlZCwgSnVsIDI5LCAyMDE1IGF0IDAyOjQ5OjQ1UE0gKzAzMDAsIEFuZGVyIENvbnNlbHZh biBEZSBPbGl2ZWlyYSAKPiB3cm90ZToKPiA+IE9uIE1vbiwgMjAxNS0wNy0yNyBhdCAxNDozNSAr MDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gPiA+IEluc3RlYWQgb2YgYWxsb2NhdGlu ZyBwaXBlX2NvbmZpZyBvbiB0aGUgc3RhY2sgdXNlIHRoZSBvbGQgCj4gPiA+IGNydGNfc3RhdGUs Cj4gPiA+IGl0J3Mgb25seSBnb2luZyB0byBmcmVlZCBmcm9tIHRoaXMgcG9pbnQgb24uCj4gPiA+ IAo+ID4gPiBBbGwgY3J0YydzIGVuY29kZXJzIGFyZSBub3cgb25seSBjaGVja2VkIG9uY2UgZHVy aW5nIG1vZGVzZXQuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3Jz dCA8Cj4gPiA+IG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+ID4gLS0tCj4g PiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAxMTggKysrKysrKysr KysrKysrKystLS0tCj4gPiA+IC0tLS0tLS0tLS0tLS0tCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwg NTYgaW5zZXJ0aW9ucygrKSwgNjIgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIAo+ID4gPiBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gPiBpbmRleCBmYmIyNTdkNDcyOGMuLmUz YWZlNjExYTc4YyAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku Ywo+ID4gPiBAQCAtMTE4MjksNyArMTE4MjksNyBAQCBzdGF0aWMgaW50IGludGVsX2NydGNfYXRv bWljX2NoZWNrKHN0cnVjdCAKPiA+ID4gZHJtX2NydGMgKmNydGMsCj4gPiA+ICAJc3RydWN0IGlu dGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnID0KPiA+ID4gIAkJdG9faW50ZWxfY3J0Y19zdGF0 ZShjcnRjX3N0YXRlKTsKPiA+ID4gIAlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUgPSBj cnRjX3N0YXRlLT5zdGF0ZTsKPiA+ID4gLQlpbnQgcmV0LCBpZHggPSBjcnRjLT5iYXNlLmlkOwo+ ID4gPiArCWludCByZXQ7Cj4gPiA+ICAJYm9vbCBtb2RlX2NoYW5nZWQgPSBuZWVkc19tb2Rlc2V0 KGNydGNfc3RhdGUpOwo+ID4gPiAgCj4gPiA+ICAJaWYgKG1vZGVfY2hhbmdlZCAmJiAhY2hlY2tf ZW5jb2Rlcl9jbG9uaW5nKHN0YXRlLCAKPiA+ID4gaW50ZWxfY3J0YykpIHsKPiA+ID4gQEAgLTEx ODM3LDEwICsxMTgzNyw2IEBAIHN0YXRpYyBpbnQgCj4gPiA+IGludGVsX2NydGNfYXRvbWljX2No ZWNrKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiA+ID4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4gPiA+ ICAJfQo+ID4gPiAgCj4gPiA+IC0JSTkxNV9TVEFURV9XQVJOKGNydGMtPnN0YXRlLT5hY3RpdmUg IT0gaW50ZWxfY3J0Ywo+ID4gPiAtPmFjdGl2ZSwKPiA+ID4gLQkJIltDUlRDOiVpXSBtaXNtYXRj aCBiZXR3ZWVuIHN0YXRlLT5hY3RpdmUoJWkpIAo+ID4gPiBhbmQgY3J0Yy0+YWN0aXZlKCVpKVxu IiwKPiA+ID4gLQkJaWR4LCBjcnRjLT5zdGF0ZS0+YWN0aXZlLCBpbnRlbF9jcnRjLT5hY3RpdmUp Owo+ID4gPiAtCj4gPiA+ICAJaWYgKG1vZGVfY2hhbmdlZCAmJiAhY3J0Y19zdGF0ZS0+YWN0aXZl KQo+ID4gPiAgCQlpbnRlbF9jcnRjLT5hdG9taWMudXBkYXRlX3dtX3Bvc3QgPSB0cnVlOwo+ID4g PiAgCj4gPiA+IEBAIC0xMjcyMSwxOSArMTI3MTcsMTYgQEAgY2hlY2tfZW5jb2Rlcl9zdGF0ZShz dHJ1Y3QgZHJtX2RldmljZSAKPiA+ID4gKmRldikKPiA+ID4gIAo+ID4gPiAgCWZvcl9lYWNoX2lu dGVsX2VuY29kZXIoZGV2LCBlbmNvZGVyKSB7Cj4gPiA+ICAJCWJvb2wgZW5hYmxlZCA9IGZhbHNl Owo+ID4gPiAtCQlib29sIGFjdGl2ZSA9IGZhbHNlOwo+ID4gPiAtCQllbnVtIHBpcGUgcGlwZSwg dHJhY2tlZF9waXBlOwo+ID4gPiArCQllbnVtIHBpcGUgcGlwZTsKPiA+ID4gIAo+ID4gPiAgCQlE Uk1fREVCVUdfS01TKCJbRU5DT0RFUjolZDolc11cbiIsCj4gPiA+ICAJCQkgICAgICBlbmNvZGVy LT5iYXNlLmJhc2UuaWQsCj4gPiA+ICAJCQkgICAgICBlbmNvZGVyLT5iYXNlLm5hbWUpOwo+ID4g PiAgCj4gPiA+ICAJCWZvcl9lYWNoX2ludGVsX2Nvbm5lY3RvcihkZXYsIGNvbm5lY3Rvcikgewo+ ID4gPiAtCQkJaWYgKGNvbm5lY3Rvci0+YmFzZS5lbmNvZGVyICE9ICZlbmNvZGVyCj4gPiA+IC0+ YmFzZSkKPiA+ID4gKwkJCWlmIChjb25uZWN0b3ItPmJhc2Uuc3RhdGUtPmJlc3RfZW5jb2RlciAK PiA+ID4gIT0gJmVuY29kZXItPmJhc2UpCj4gPiA+ICAJCQkJY29udGludWU7Cj4gPiA+ICAJCQll bmFibGVkID0gdHJ1ZTsKPiA+ID4gLQkJCWlmIChjb25uZWN0b3ItPmJhc2UuZHBtcyAhPSAKPiA+ ID4gRFJNX01PREVfRFBNU19PRkYpCj4gPiA+IC0JCQkJYWN0aXZlID0gdHJ1ZTsKPiA+ID4gIAo+ ID4gPiAgCQkJSTkxNV9TVEFURV9XQVJOKGNvbm5lY3Rvci0+YmFzZS5zdGF0ZQo+ID4gPiAtPmNy dGMgIT0KPiA+ID4gIAkJCQkJZW5jb2Rlci0+YmFzZS5jcnRjLAo+ID4gPiBAQCAtMTI3NDQsODUg KzEyNzM3LDg2IEBAIGNoZWNrX2VuY29kZXJfc3RhdGUoc3RydWN0IGRybV9kZXZpY2UgCj4gPiA+ ICpkZXYpCj4gPiA+ICAJCSAgICAgImVuY29kZXIncyBlbmFibGVkIHN0YXRlIG1pc21hdGNoICIK PiA+ID4gIAkJICAgICAiKGV4cGVjdGVkICVpLCBmb3VuZCAlaSlcbiIsCj4gPiA+ICAJCSAgICAg ISFlbmNvZGVyLT5iYXNlLmNydGMsIGVuYWJsZWQpOwo+ID4gPiAtCQlJOTE1X1NUQVRFX1dBUk4o YWN0aXZlICYmICFlbmNvZGVyLT5iYXNlLmNydGMsCj4gPiA+IC0JCSAgICAgImFjdGl2ZSBlbmNv ZGVyIHdpdGggbm8gY3J0Y1xuIik7Cj4gPiA+IC0KPiA+ID4gLQkJYWN0aXZlID0gZW5jb2Rlci0+ Z2V0X2h3X3N0YXRlKGVuY29kZXIsICZwaXBlKTsKPiA+ID4gIAo+ID4gPiAgCQlpZiAoIWVuY29k ZXItPmJhc2UuY3J0Yykgewo+ID4gPiAtCQkJSTkxNV9TVEFURV9XQVJOKGFjdGl2ZSwKPiA+ID4g LQkJCSAgICAgImVuY29kZXIgZGV0YWNoZWQgYnV0IG5vdCB0dXJuZWQgCj4gPiA+IG9mZi5cbiIp Owo+ID4gPiArCQkJYm9vbCBhY3RpdmU7Cj4gPiA+ICAKPiA+ID4gLQkJCWNvbnRpbnVlOwo+ID4g PiArCQkJYWN0aXZlID0gZW5jb2Rlci0+Z2V0X2h3X3N0YXRlKGVuY29kZXIsIAo+ID4gPiAmcGlw ZSk7Cj4gPiA+ICsJCQlJOTE1X1NUQVRFX1dBUk4oYWN0aXZlLAo+ID4gPiArCQkJICAgICAiZW5j b2RlciBkZXRhY2hlZCBidXQgc3RpbGwgZW5hYmxlZCAKPiA+ID4gb24gcGlwZSAlYy5cbiIsCj4g PiA+ICsJCQkgICAgIHBpcGVfbmFtZShwaXBlKSk7Cj4gPiA+ICAJCX0KPiA+ID4gLQo+ID4gPiAt CQlJOTE1X1NUQVRFX1dBUk4oYWN0aXZlICE9IGVuY29kZXItPmJhc2UuY3J0Ywo+ID4gPiAtPnN0 YXRlLT5hY3RpdmUsCj4gPiA+IC0JCSAgICAgImVuY29kZXIncyBodyBzdGF0ZSBkb2Vzbid0IG1h dGNoIHN3IAo+ID4gPiB0cmFja2luZyAiCj4gPiA+IC0JCSAgICAgIihleHBlY3RlZCAlaSwgZm91 bmQgJWkpXG4iLAo+ID4gPiAtCQkgICAgIGVuY29kZXItPmJhc2UuY3J0Yy0+c3RhdGUtPmFjdGl2 ZSwgYWN0aXZlKTsKPiA+ID4gLQo+ID4gPiAtCj4gPiA+IC0JCXRyYWNrZWRfcGlwZSA9IHRvX2lu dGVsX2NydGMoZW5jb2Rlci0+YmFzZS5jcnRjKQo+ID4gPiAtPnBpcGU7Cj4gPiA+IC0JCUk5MTVf U1RBVEVfV0FSTihhY3RpdmUgJiYgcGlwZSAhPSB0cmFja2VkX3BpcGUsCj4gPiA+IC0JCSAgICAg ImFjdGl2ZSBlbmNvZGVyJ3MgcGlwZSBkb2Vzbid0IG1hdGNoIgo+ID4gPiAtCQkgICAgICIoZXhw ZWN0ZWQgJWksIGZvdW5kICVpKVxuIiwKPiA+ID4gLQkJICAgICB0cmFja2VkX3BpcGUsIHBpcGUp Owo+ID4gPiAtCj4gPiA+ICAJfQo+ID4gPiAgfQo+ID4gPiAgCj4gPiA+ICBzdGF0aWMgdm9pZAo+ ID4gPiAtY2hlY2tfY3J0Y19zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4gPiArY2hl Y2tfY3J0Y19zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2F0b21pY19z dGF0ZSAKPiA+ID4gKnN0YXRlKQo+ID4gPiAgewo+ID4gPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gPiA+IC0Jc3RydWN0IGludGVsX2Ny dGMgKmNydGM7Cj4gPiA+ICAJc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXI7Cj4gPiA+IC0J c3RydWN0IGludGVsX2NydGNfc3RhdGUgcGlwZV9jb25maWc7Cj4gPiA+ICsJc3RydWN0IGRybV9j cnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+ID4gPiArCXN0cnVjdCBkcm1fY3J0YyAqY3J0YzsKPiA+ ID4gKwlpbnQgaTsKPiA+ID4gIAo+ID4gPiAtCWZvcl9lYWNoX2ludGVsX2NydGMoZGV2LCBjcnRj KSB7Cj4gPiA+ICsJZm9yX2VhY2hfY3J0Y19pbl9zdGF0ZShzdGF0ZSwgY3J0YywgY3J0Y19zdGF0 ZSwgaSkgewo+ID4gCj4gPiBTbyBub3cgd2Ugb25seSBjaGVjayB0aGUgc3RhdGUgb2YgY3J0Y3Mg YWZmZWN0ZWQgYnkgdGhlIG1vZGVzZXQuIEluIAo+ID4gdGhlCj4gPiB1bmxpa2VseSBjYXNlIG9m IGEgYnVnIHRoYXQgY2hhbmdlcyB0aGUgaHcgc3RhdGUgb2YgYW5vdGhlciBjcnRjIAo+ID4gdGhh dAo+ID4gc2hvdWxkIGhhdmUgYmVlbiB1bmNoYW5nZWQsIHRoZSBvbGQgY29kZSBtaWdodCBjYXRj aCB0aGUgaXNzdWUgYnV0IAo+ID4gdGhlCj4gPiBuZXcgb25lIGRvZXNuJ3QuIElzbid0IGl0IGJl dHRlciB0byBqdXN0IGNoZWNrIGV2ZXJ5dGhpbmc/Cj4gCj4gV2UgY2FuJ3Qgc2luY2UgdGhhdCBv dGhlciBjcnRjIG1pZ2h0IGJlIGRvaW5nIHNvbWUgb3RoZXIgYXN5bmMgCj4gY29tbWl0LiBCdXQK PiBldmVudHVhbGx5IHdlIHNob3VsZCBiZSBkb2luZyBhIG1vZGVzZXQgb24gdGhhdCBvbmUgdG9v IGFuZCBzcG90IHRoYXQKPiBzb21ldGhpbmcgd2VudCB3cm9uZy4KClJpZ2h0LCBJIGZvcmdvdCBh Ym91dCBhc3luYy4KClJldmlld2VkLWJ5OiBBbmRlciBDb25zZWx2YW4gZGUgT2xpdmVpcmEgPGNv bnNlbHZhbjJAZ21haWwuY29tPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK