From: <gregkh@linuxfoundation.org>
To: mchehab@osg.samsung.com, gregkh@linuxfoundation.org
Cc: <stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Patch "[media] s5h1420: fix a buffer overflow when checking userspace params" has been added to the 4.1-stable tree
Date: Wed, 29 Jul 2015 17:25:57 -0700 [thread overview]
Message-ID: <1438215957268@kroah.com> (raw)
This is a note to let you know that I've just added the patch titled
[media] s5h1420: fix a buffer overflow when checking userspace params
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
s5h1420-fix-a-buffer-overflow-when-checking-userspace-params.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 12f4543f5d6811f864e6c4952eb27253c7466c02 Mon Sep 17 00:00:00 2001
From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Date: Tue, 28 Apr 2015 18:34:40 -0300
Subject: [media] s5h1420: fix a buffer overflow when checking userspace params
From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
commit 12f4543f5d6811f864e6c4952eb27253c7466c02 upstream.
The maximum size for a DiSEqC command is 6, according to the
userspace API. However, the code allows to write up to 7 values:
drivers/media/dvb-frontends/s5h1420.c:193 s5h1420_send_master_cmd() error: buffer overflow 'cmd->msg' 6 <= 7
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/media/dvb-frontends/s5h1420.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/media/dvb-frontends/s5h1420.c
+++ b/drivers/media/dvb-frontends/s5h1420.c
@@ -180,7 +180,7 @@ static int s5h1420_send_master_cmd (stru
int result = 0;
dprintk("enter %s\n", __func__);
- if (cmd->msg_len > 8)
+ if (cmd->msg_len > sizeof(cmd->msg))
return -EINVAL;
/* setup for DISEQC */
Patches currently in stable-queue which might be from mchehab@osg.samsung.com are
queue-4.1/media-fix-regression-in-some-more-dib0700-based-devices.patch
queue-4.1/cx24116-fix-a-buffer-overflow-when-checking-userspace-params.patch
queue-4.1/saa7164-fix-querycap-warning.patch
queue-4.1/vb2-don-t-warn-when-v4l2_buffer.bytesused-is-0-for-multiplanar-buffers.patch
queue-4.1/s5h1420-fix-a-buffer-overflow-when-checking-userspace-params.patch
queue-4.1/rc-core-fix-dib0700-scancode-generation-for-rc5.patch
queue-4.1/cx24117-fix-a-buffer-overflow-when-checking-userspace-params.patch
queue-4.1/af9013-don-t-accept-invalid-bandwidth.patch
queue-4.1/cx18-add-missing-caps-for-the-pcm-video-device.patch
reply other threads:[~2015-07-30 0:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438215957268@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=mchehab@osg.samsung.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.