From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752345AbbG3Fim (ORCPT ); Thu, 30 Jul 2015 01:38:42 -0400 Received: from smtprelay0098.hostedemail.com ([216.40.44.98]:39037 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751449AbbG3Fil (ORCPT ); Thu, 30 Jul 2015 01:38:41 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:968:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3871:3872:3874:4321:5007:6261:6691:10004:10400:10848:11026:11232:11657:11658:11914:12043:12296:12517:12519:12740:13019:13069:13161:13229:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: bit52_689f1b448e445 X-Filterd-Recvd-Size: 1830 Message-ID: <1438234716.2677.8.camel@perches.com> Subject: Re: [PATCH 4573/4573] Staging: rtl8188eu: fixed newlines after declarations From: Joe Perches To: Dave Perez Cc: gregkh@linuxfoundation.org, tapaswenipathak@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Wed, 29 Jul 2015 22:38:36 -0700 In-Reply-To: <1438220082-4599-1-git-send-email-dave@daveperez.com> References: <1438220082-4599-1-git-send-email-dave@daveperez.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-07-29 at 21:34 -0400, Dave Perez wrote: > This is a patch to the rtw_debug.c file that fixes styling errors relating to new lines after variable declarations. [] > diff --git a/drivers/staging/rtl8188eu/core/rtw_debug.c b/drivers/staging/rtl8188eu/core/rtw_debug.c [] > @@ -219,6 +219,7 @@ int proc_get_ht_option(char *page, char **start, > struct mlme_priv *pmlmepriv = &(padapter->mlmepriv); > > int len = 0; > + > len += snprintf(page + len, count - len, "ht_option=%d\n", pmlmepriv->htpriv.ht_option); > *eof = 1; > return len; the blank line before "int len = 0" could also be removed. The routine _could_ be rewritten more simply as: struct mlme_priv *pmlmepriv = &padapter->mlmepriv; int len = snprintf(page, count, "ht_option=%d\n", pmlmepriv->htpriv.htoption); *eof = 1; return len; } but there are a bunch of other routines that use this form so it's probably fine as-is.