All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	Ravi Sahita <ravi.sahita@intel.com>,
	xen-devel@lists.xenproject.org
Cc: george.dunlap@eu.citrix.com, wei.liu2@citrix.com, tim@xen.org,
	edmund.h.white@intel.com, JBeulich@suse.com
Subject: Re: [PATCH for 4.6] x86/hvm.c: fix regression in guest destruction
Date: Thu, 30 Jul 2015 10:21:01 +0100	[thread overview]
Message-ID: <1438248061.11600.265.camel@citrix.com> (raw)
In-Reply-To: <55B902F6.3040005@citrix.com>

On Wed, 2015-07-29 at 17:44 +0100, Andrew Cooper wrote:
> On 29/07/15 17:39, Ravi Sahita wrote:
> > As reported by Wei Lu on July 27 2015
> 
> Reported-by: Wei Liu <wei.liu2@citrix.com>

Which leaves an effectively empty commit message:

    x86/hvm.c: fix regression in guest destruction

    Reported-by: Wei Liu <    wei.liu2@citrix.com    >
    Signed-off-by: Ravi Sahita <    ravi.sahita@intel.com    >
    Reviewed-by: Andrew Cooper <    andrew.cooper3@citrix.com    >
    Tested-by: Wei Liu <    wei.liu2@citrix.com    >

If I were maintainer of this code I'd be very grumpy about the lack of a
commit log (What regression? What is the fix? Why is it correct?) for this
patch. I asked on IRC and Andy suggested instead:

    x86/hvm.c: Don't tear down altp2m state if it was never set up

which I have applied with. I still don't think the commit message is very
satisfactory, but I'm not maintainer of any of this code so meh.

Ian.

  parent reply	other threads:[~2015-07-30  9:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-29 16:39 [PATCH for 4.6] x86/hvm.c: fix regression in guest destruction Ravi Sahita
2015-07-29 16:44 ` Andrew Cooper
2015-07-29 16:51   ` Wei Liu
2015-07-30  9:21   ` Ian Campbell [this message]
2015-07-30  9:32     ` Ian Campbell
2015-07-30  9:38       ` George Dunlap
2015-07-30  9:50         ` Ian Campbell
2015-07-30  9:55       ` Andrew Cooper
2015-07-30 10:08         ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438248061.11600.265.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=edmund.h.white@intel.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=ravi.sahita@intel.com \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.