From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for 4.6] x86/hvm.c: fix regression in guest destruction Date: Thu, 30 Jul 2015 10:21:01 +0100 Message-ID: <1438248061.11600.265.camel@citrix.com> References: <1438187962-4047-1-git-send-email-ravi.sahita@intel.com> <55B902F6.3040005@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZKk1S-0005eP-Ee for xen-devel@lists.xenproject.org; Thu, 30 Jul 2015 09:21:06 +0000 In-Reply-To: <55B902F6.3040005@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , Ravi Sahita , xen-devel@lists.xenproject.org Cc: george.dunlap@eu.citrix.com, wei.liu2@citrix.com, tim@xen.org, edmund.h.white@intel.com, JBeulich@suse.com List-Id: xen-devel@lists.xenproject.org On Wed, 2015-07-29 at 17:44 +0100, Andrew Cooper wrote: > On 29/07/15 17:39, Ravi Sahita wrote: > > As reported by Wei Lu on July 27 2015 > > Reported-by: Wei Liu Which leaves an effectively empty commit message: x86/hvm.c: fix regression in guest destruction Reported-by: Wei Liu < wei.liu2@citrix.com > Signed-off-by: Ravi Sahita < ravi.sahita@intel.com > Reviewed-by: Andrew Cooper < andrew.cooper3@citrix.com > Tested-by: Wei Liu < wei.liu2@citrix.com > If I were maintainer of this code I'd be very grumpy about the lack of a commit log (What regression? What is the fix? Why is it correct?) for this patch. I asked on IRC and Andy suggested instead: x86/hvm.c: Don't tear down altp2m state if it was never set up which I have applied with. I still don't think the commit message is very satisfactory, but I'm not maintainer of any of this code so meh. Ian.